ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Renable Strict TSLint (#5018)

Browse Source 
* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files
This commit is contained in:
Anthony Dresser
2019-04-18 00:34:53 -07:00
committed by GitHub
parent b852f032d3
commit ddd89fc52a
431 changed files with 3147 additions and 3789 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/all.js
View File

@@ -48,7 +48,7 @@ function main() {
console.error(e.stack || e);
});
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
var loaderConfig = {
nodeRequire: require,
nodeMain: __filename,
@@ -87,7 +87,7 @@ function main() {
loaderConfig.nodeInstrumenter = function (contents, source) {
seenSources[source] = true;
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
if (minimatch(source, SQL_TEST_GLOB)) {
return contents;
}
@@ -162,7 +162,7 @@ function main() {
for (var entryKey in remappedCoverage) {
var entry = remappedCoverage[entryKey];
entry.path = fixPath(entry.path);
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
if (!entry.path.includes('\\vs\\') && !entry.path.includes('/vs/')) {
finalCoverage[fixPath(entryKey)] = entry;
}
@@ -179,7 +179,7 @@ function main() {
coveragePath += '-single';
reportTypes = ['lcovonly'];
} else {
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
reportTypes = ['json', 'lcov', 'html', 'cobertura'];
}
var reporter = new istanbul.Reporter(null, coveragePath);
@@ -199,7 +199,7 @@ function main() {
global.Node = global.window.Node;
global.navigator = global.window.navigator;
global.XMLHttpRequest = global.window.XMLHttpRequest;
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
global.Event = global.window.Event;
require('reflect-metadata');
@@ -306,14 +306,14 @@ function main() {
}
});
});
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
*/
// replace the default unexpected error handler to be useful during tests
loader(['vs/base/common/errors'], function (errors) {
errors.setUnexpectedErrorHandler(function (err) {
let stack = (err && err.stack) || (new Error().stack);
// {{SQL CARBON EDIT}}
// {{SQL CARBON EDIT}}
//unexpectedErrors.push((err && err.message ? err.message : err) + '\n' + stack);
});

5
test/smoke/src/sql/sqlutils.ts
View File

@@ -1,3 +1,8 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { Code } from '../vscode/code';
export async function waitForNewDialog(code: Code, title: string) {

10
test/smoke/src/sql/testConfig.ts
View File

@@ -41,8 +41,8 @@ export enum EngineType {
BigDataCluster
}
var connectionProviderMapping = {};
var authenticationTypeMapping = {};
let connectionProviderMapping = {};
let authenticationTypeMapping = {};
connectionProviderMapping[ConnectionProvider.SQLServer] = { name: 'MSSQL', displayName: 'Microsoft SQL Server' };
authenticationTypeMapping[AuthenticationType.SqlLogin] = { name: 'SqlLogin', displayName: 'SQL Login' };
@@ -80,7 +80,7 @@ export class TestServerProfile {
public get engineType(): EngineType { return this._profile.engineType; }
}
var TestingServers: TestServerProfile[] = [
let TestingServers: TestServerProfile[] = [
new TestServerProfile(
{
serverName: getConfigValue(EnvironmentVariable_STANDALONE_SERVER),
@@ -121,7 +121,7 @@ function getEnumMappingEntry(mapping: any, enumValue: any): INameDisplayNamePair
if (entry) {
return entry;
} else {
throw `Unknown enum type: ${enumValue.toString()}`;
throw new Error(`Unknown enum type: ${enumValue.toString()}`);
}
}
@@ -146,4 +146,4 @@ export async function getTestingServers(): Promise<TestServerProfile[]> {
});
await promise;
return promise;
}
}