From de5fd11155a441ca25d448c669742fb1237afc04 Mon Sep 17 00:00:00 2001 From: Amir Omidi Date: Thu, 17 Oct 2019 10:55:16 -0700 Subject: [PATCH] Add some more asserts to integration tests (#7759) --- extensions/integration-tests/src/notebook.test.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/extensions/integration-tests/src/notebook.test.ts b/extensions/integration-tests/src/notebook.test.ts index 219efe1749..cb394ac628 100644 --- a/extensions/integration-tests/src/notebook.test.ts +++ b/extensions/integration-tests/src/notebook.test.ts @@ -161,14 +161,23 @@ class NotebookTester { for (let i = 0; i < 3; i++) { let cellOutputs = notebook.document.cells[i].contents.outputs; console.log(`Got cell outputs --- ${i}`); + if (cellOutputs) { - cellOutputs.forEach(o => console.log(o)); + cellOutputs.forEach(console.log); } + assert(cellOutputs.length === 3, `Expected length: 3, Actual: '${cellOutputs.length}'`); let actualOutput0 = (cellOutputs[0]).data['text/html']; console.log('Got first output'); assert(actualOutput0 === expectedOutput0, `Expected row count: '${expectedOutput0}', Actual: '${actualOutput0}'`); - let actualOutput2 = (cellOutputs[2]).data['application/vnd.dataresource+json'].data[0]; + + const executeResult = cellOutputs[2] as azdata.nb.IExecuteResult; + assert(Object.keys(executeResult).includes('data'), `Execute result did not include data key. It included ${Object.keys(executeResult)}`); + const applicationDataResource = executeResult.data['application/vnd.dataresource+json']; + + assert(Object.keys(applicationDataResource).includes('data'), `Execute result did not include data key. It included ${Object.keys(applicationDataResource)}`); + const actualOutput2 = applicationDataResource.data[0]; + assert(actualOutput2[0] === i.toString(), `Expected result: ${i.toString()}, Actual: '${actualOutput2[0]}'`); console.log('Sql multiple cells NB done'); }