ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-21 17:22:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

No unused locals (#8231)

Browse Source 
* add no unused local

* fix strict null

* fix compile errors

* update vscode comments
This commit is contained in:
Anthony Dresser
2019-11-06 17:22:05 -08:00
committed by GitHub
parent 564f78b6f6
commit df0c505452
147 changed files with 726 additions and 892 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts
View File

@@ -73,7 +73,7 @@ const notebookRegistry = Registry.as<INotebookProviderRegistry>(Extensions.Noteb
class ProviderDescriptor {
private _instanceReady = new Deferred<INotebookProvider>();
constructor(private providerId: string, private _instance?: INotebookProvider) {
constructor(private _instance?: INotebookProvider) {
if (_instance) {
this._instanceReady.resolve(_instance);
}
@@ -243,7 +243,7 @@ export class NotebookService extends Disposable implements INotebookService {
let registration = p.registration;
if (!this._providers.has(p.id)) {
this._providers.set(p.id, new ProviderDescriptor(p.id));
this._providers.set(p.id, new ProviderDescriptor());
}
if (registration.fileExtensions) {
if (Array.isArray<string>(registration.fileExtensions)) {
@@ -266,7 +266,7 @@ export class NotebookService extends Disposable implements INotebookService {
// Update, which will resolve the promise for anyone waiting on the instance to be registered
providerDescriptor.instance = instance;
} else {
this._providers.set(providerId, new ProviderDescriptor(providerId, instance));
this._providers.set(providerId, new ProviderDescriptor(instance));
}
}