ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-31 09:35:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove disposable from connection (#22687)

Browse Source 
* Remove disposable from connection

* Remove from group
This commit is contained in:
Charles Gagnon
2023-04-11 15:27:01 -07:00
committed by GitHub
parent 219bdabfb2
commit df88d881c5
11 changed files with 10 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/platform/connection/common/connectionStore.ts
View File

@@ -181,10 +181,8 @@ export class ConnectionStore {
}
public getProfileWithoutPassword(conn: IConnectionProfile): ConnectionProfile {
let savedConn = ConnectionProfile.fromIConnectionProfile(this.capabilitiesService, conn);
let newSavedConn = savedConn.withoutPassword();
savedConn.dispose();
return newSavedConn;
const savedConn = ConnectionProfile.fromIConnectionProfile(this.capabilitiesService, conn);
return savedConn.withoutPassword();
}
/**
@@ -229,9 +227,7 @@ export class ConnectionStore {
list.unshift(savedProfile);
const profiles = list.filter(n => n !== undefined).map(c => c.toIConnectionProfile());
list.forEach(c => c.dispose());
return profiles;
return list.filter(n => n !== undefined).map(c => c.toIConnectionProfile());
}
private removeFromConnectionList(conn: IConnectionProfile, list: ConnectionProfile[]): IConnectionProfile[] {