From dfb1d5411e62f6f6d047a1684308ab43255f2208 Mon Sep 17 00:00:00 2001
From: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Date: Thu, 22 Oct 2020 10:24:11 -0700
Subject: [PATCH] Don't open schema compare if project build fails (#13027)

* don't open schema compare if project build fails

* update error message
---
 extensions/sql-database-projects/src/common/constants.ts  | 2 +-
 .../src/controllers/projectController.ts                  | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/extensions/sql-database-projects/src/common/constants.ts b/extensions/sql-database-projects/src/common/constants.ts
index 9b531e9105..1afdeda920 100644
--- a/extensions/sql-database-projects/src/common/constants.ts
+++ b/extensions/sql-database-projects/src/common/constants.ts
@@ -133,7 +133,7 @@ export const projectLocationRequired = localize('projectLocationRequired', "Loca
 export const projectLocationNotEmpty = localize('projectLocationNotEmpty', "Current project location is not empty. Select an empty folder for precise extraction.");
 export const extractTargetRequired = localize('extractTargetRequired', "Target information for extract is required to create database project.");
 export const schemaCompareNotInstalled = localize('schemaCompareNotInstalled', "Schema compare extension installation is required to run schema compare");
-export const buildDacpacNotFound = localize('buildDacpacNotFound', "Dacpac created from build not found");
+export const buildFailedCannotStartSchemaCompare = localize('buildFailedCannotStartSchemaCompare', "Schema compare could not start because build failed");
 export const updateProjectForRoundTrip = localize('updateProjectForRoundTrip', "To build this project, Azure Data Studio needs to update targets, references, and system database references. If the project is created in SSDT, it will continue to work in both tools. Do you want Azure Data Studio to update the project?");
 export const updateProjectDatabaseReferencesForRoundTrip = localize('updateProjectDatabaseReferencesForRoundTrip', "To build this project, Azure Data Studio needs to update system database references. If the project is created in SSDT, it will continue to work in both tools. Do you want Azure Data Studio to update the project?");
 export const databaseReferenceTypeRequired = localize('databaseReferenceTypeRequired', "Database reference type is required for adding a reference to a database");
diff --git a/extensions/sql-database-projects/src/controllers/projectController.ts b/extensions/sql-database-projects/src/controllers/projectController.ts
index bcd3cf8e0f..a0940d8968 100644
--- a/extensions/sql-database-projects/src/controllers/projectController.ts
+++ b/extensions/sql-database-projects/src/controllers/projectController.ts
@@ -272,17 +272,13 @@ export class ProjectsController {
 		// check if schema compare extension is installed
 		if (vscode.extensions.getExtension(constants.schemaCompareExtensionId)) {
 			// build project
-			await this.buildProject(treeNode);
-
-			// start schema compare with the dacpac produced from build
-			const project = this.getProjectFromContext(treeNode);
-			const dacpacPath = path.join(project.projectFolderPath, 'bin', 'Debug', `${project.projectFileName}.dacpac`);
+			const dacpacPath = await this.buildProject(treeNode);
 
 			// check that dacpac exists
 			if (await utils.exists(dacpacPath)) {
 				await vscode.commands.executeCommand(constants.schemaCompareStartCommand, dacpacPath);
 			} else {
-				vscode.window.showErrorMessage(constants.buildDacpacNotFound);
+				vscode.window.showErrorMessage(constants.buildFailedCannotStartSchemaCompare);
 			}
 		} else {
 			vscode.window.showErrorMessage(constants.schemaCompareNotInstalled);