ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove controller endpoint from Data Controller dashboard. (#16647)

Browse Source 
Co-authored-by: Candice Ye <canye@microsoft.com>
This commit is contained in:
Candice Ye
2021-08-10 15:38:39 -07:00
committed by GitHub
parent e0143e0752
commit dfc91cc0ff
2 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/arc/src/localizedConstants.ts
View File

@@ -57,7 +57,6 @@ export const name = localize('arc.name', "Name");
export const type = localize('arc.type', "Type"); export const type = localize('arc.type', "Type");
export const status = localize('arc.status', "Status"); export const status = localize('arc.status', "Status");
export const miaaAdmin = localize('arc.miaaAdmin', "Managed instance admin"); export const miaaAdmin = localize('arc.miaaAdmin', "Managed instance admin");
export const controllerEndpoint = localize('arc.controllerEndpoint', "Controller endpoint");
export const extensionName = localize('arc.extensionName', "Extension name"); export const extensionName = localize('arc.extensionName', "Extension name");
export const extensionsDescription = localize('arc.extensionsDescription', "PostgreSQL provides the ability to extend the functionality of your database by using extensions. Extensions allow for bundling multiple related SQL objects together in a single package that can be loaded or removed from your database with a single command. After being loaded in the database, extensions can function like built-in features."); export const extensionsDescription = localize('arc.extensionsDescription', "PostgreSQL provides the ability to extend the functionality of your database by using extensions. Extensions allow for bundling multiple related SQL objects together in a single package that can be loaded or removed from your database with a single command. After being loaded in the database, extensions can function like built-in features.");
export const extensionsFunction = localize('arc.extensionsFunction', "Some extensions must be loaded into PostgreSQL at startup time before they can be used. These preloaded extensions can be viewed and edited below."); export const extensionsFunction = localize('arc.extensionsFunction', "Some extensions must be loaded into PostgreSQL at startup time before they can be used. These preloaded extensions can be viewed and edited below.");

17
extensions/arc/src/ui/dashboards/controller/controllerDashboardOverviewPage.ts
View File

@@ -8,7 +8,7 @@ import * as azdata from 'azdata';
import * as azurecore from 'azurecore'; import * as azurecore from 'azurecore';
import * as vscode from 'vscode'; import * as vscode from 'vscode';
import { getConnectionModeDisplayText, getResourceTypeIcon, resourceTypeToDisplayName } from '../../../common/utils'; import { getConnectionModeDisplayText, getResourceTypeIcon, resourceTypeToDisplayName } from '../../../common/utils';
import { cssStyles, Endpoints, IconPathHelper, controllerTroubleshootDocsUrl, iconSize } from '../../../constants'; import { cssStyles, IconPathHelper, controllerTroubleshootDocsUrl, iconSize } from '../../../constants';
import * as loc from '../../../localizedConstants'; import * as loc from '../../../localizedConstants';
import { ControllerModel } from '../../../models/controllerModel'; import { ControllerModel } from '../../../models/controllerModel';
import { DashboardPage } from '../../components/dashboardPage'; import { DashboardPage } from '../../components/dashboardPage';
@@ -30,7 +30,6 @@ export class ControllerDashboardOverviewPage extends DashboardPage {
resourceGroupName: '-', resourceGroupName: '-',
location: '-', location: '-',
subscriptionId: '-', subscriptionId: '-',
controllerEndpoint: '-',
connectionMode: '-', connectionMode: '-',
instanceNamespace: '-', instanceNamespace: '-',
}; };
@@ -41,8 +40,7 @@ export class ControllerDashboardOverviewPage extends DashboardPage {
this._azurecoreApi = vscode.extensions.getExtension(azurecore.extension.name)?.exports; this._azurecoreApi = vscode.extensions.getExtension(azurecore.extension.name)?.exports;
this.disposables.push( this.disposables.push(
this._controllerModel.onRegistrationsUpdated(() => this.eventuallyRunOnInitialized(() => this.handleRegistrationsUpdated())), this._controllerModel.onRegistrationsUpdated(() => this.eventuallyRunOnInitialized(() => this.handleRegistrationsUpdated())));
this._controllerModel.onEndpointsUpdated(() => this.eventuallyRunOnInitialized(() => this.handleEndpointsUpdated())));
} }
public get title(): string { public get title(): string {
@@ -107,7 +105,6 @@ export class ControllerDashboardOverviewPage extends DashboardPage {
// Update loaded components with data // Update loaded components with data
this.handleRegistrationsUpdated(); this.handleRegistrationsUpdated();
this.handleEndpointsUpdated();
// Assign the loading component after it has data // Assign the loading component after it has data
this._propertiesLoadingComponent.component = this._propertiesContainer; this._propertiesLoadingComponent.component = this._propertiesContainer;
@@ -259,12 +256,6 @@ export class ControllerDashboardOverviewPage extends DashboardPage {
this._arcResourcesLoadingComponent.loading = !this._controllerModel.registrationsLastUpdated; this._arcResourcesLoadingComponent.loading = !this._controllerModel.registrationsLastUpdated;
} }
private handleEndpointsUpdated(): void {
const controllerEndpoint = this._controllerModel.getEndpoint(Endpoints.controller);
this.controllerProperties.controllerEndpoint = controllerEndpoint?.endpoint || this.controllerProperties.controllerEndpoint;
this.refreshDisplayedProperties();
}
private refreshDisplayedProperties(): void { private refreshDisplayedProperties(): void {
this._propertiesContainer.propertyItems = [ this._propertiesContainer.propertyItems = [
{ {
@@ -287,10 +278,6 @@ export class ControllerDashboardOverviewPage extends DashboardPage {
displayName: loc.type, displayName: loc.type,
value: loc.dataControllersType value: loc.dataControllersType
}, },
{
displayName: loc.controllerEndpoint,
value: this.controllerProperties.controllerEndpoint
},
{ {
displayName: loc.connectionMode, displayName: loc.connectionMode,
value: this.controllerProperties.connectionMode value: this.controllerProperties.connectionMode