From e09e7be7572034288beeb4427794e89aab819f82 Mon Sep 17 00:00:00 2001 From: nasc17 <69922333+nasc17@users.noreply.github.com> Date: Wed, 2 Jun 2021 15:18:54 -0700 Subject: [PATCH] May arc updates (#15609) * Postgres reduce worker node count (#15534) * Allow scale in * Fix word * Removed changing of min * Set min for worker count box * Update server tree action contributions (#15525) * Update server tree action contributions * Fix test * Updated langpacks to be pushed in (#15519) * updated langpacks to be pushed in * bumped version number to 1.29.0 * patched german lang pack * patched spanish langpack * patched french langpack * italian langpack patched * Japanese langpack patched * Korean langpack patched * portuguese langpack patched * russian langpack patched * patched chinese simplified langpack and fixed changelog for ru and pt * patched chinese traditional langpack * Init assets in dialog model (#15533) * check that there are assets before filtering * init assets as empty array * change book icon (#15539) * add sorting indicator (#15542) * Vsix build task for langpacks (#15489) * added refreshlangpack command * added beginning update-localization yml file, also changed langpack location in RLE * added regex tester * moved xlf files into new folder structure * small change to update-localization * added yaml script for gulp refresh * added missing dash. * added better update-localization yml file * remove update-localization as its not necessary * added small changes to langpack-compile * remove upload sourcemaps and write version information * added more languages * added vsce packaging * added automatic langpack handling * added built locFunc * fixed refresh-langpack-extension * working langpack vsix generator made * added langpacks to files in copyArtifacts and product-build-linux * changed command to package-langpacks * removed unnecessary language flags. * invalid ADS extensions filter explained * Fix for regex * removed unnecessary fields to change, and removed langpack-compile * added doc comments. * moved xlf files back to old place. * WIP translation redirect * isolated vsix build task * fixed spaces in locFunc.ts * use svg for sorting state icons (#15546) * Add Markdown as a default editing option for text cells (#15540) * Disable npm recompile step (#15548) * Revert "Disable npm recompile step (#15548)" (#15554) This reverts commit db5b68e04a669991d0ae63449f4d2de2599b5bff. * fix file compare issue (#15551) * Fix notebook file URI test by adding a required forward slash to Windows file paths. (#15550) * SqlToolService release version updated to 105 from 104 (#15558) * Schema Compare failing test condition set to uncomment state. (#15512) * fix changing kernels from kusto to other kernels (#15545) * adding feedback dialog and support request buttons * hide support request, widen feedback dialog * Fix extension publishing during CI build (#15561) * Disable native module recompile * Bump distro * Move web build step earlier * Dev/brih/revert feedbackdialog commits (#15567) * Revert "hide support request, widen feedback dialog" This reverts commit 1d75fcfed505713793378d2eb2f0bc5884059039. * Revert "adding feedback dialog and support request buttons" This reverts commit 866ced5c08b154df0777d7af2ab2bfb6131d9615. * Fixing a couple database reference dialog bugs (#15523) * fixing a couple database reference dialog bugs * update comment * Update action run return type (#15568) * Update action run return type * fix tests * Update rest * Add back null checks * Run with Parameters learn more link to use correct format and kernels (#15547) * indicate to users correct format and kernels * add test for unsupported kernel * replace with enum * Migraiton enhancements v: 0.1.1 (#15570) * adding filters and cards for failed migrations * Added card and filter for completing cutover * Fixing blob container support and some ux enhancements * Enabling eastus2 and canada central regions * Increasing height of container to accomodate newer cards and cleaning up database backup page * vbump migration * Removing unused code * fix css to contain image (#15574) * Bump browserslist from 4.16.3 to 4.16.6 (#15565) Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.3 to 4.16.6. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](https://github.com/browserslist/browserslist/compare/4.16.3...4.16.6) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added build changes to add TSGOps extensions into the build (#15584) * Add TSGOps specific extensions to SAW build * Added the KeyVault uri * Fix edit command to take in worker count of 0 (#15603) * Allow for worker count to be 0 * Clean up Co-authored-by: Charles Gagnon Co-authored-by: Alex Ma Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: Alan Ren Co-authored-by: Cory Rivera Co-authored-by: Karl Burtram Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com> Co-authored-by: Vasu Bhog Co-authored-by: Brian Harris Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com> Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: Aasim Khan Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rajeshka --- extensions/arc/src/localizedConstants.ts | 2 +- .../src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts | 2 +- extensions/azdata/src/azdata.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/arc/src/localizedConstants.ts b/extensions/arc/src/localizedConstants.ts index 3dcd9a606d..fcb32957c5 100644 --- a/extensions/arc/src/localizedConstants.ts +++ b/extensions/arc/src/localizedConstants.ts @@ -69,7 +69,7 @@ export const addingWorkerNodes = localize('arc.addingWorkerNodes', "adding worke export const workerNodesDescription = localize('arc.workerNodesDescription', "Expand your server group and scale your database by adding worker nodes."); export const workerNodesConfigurationInformation = localize('arc.workerNodesConfigurationInformation', "You can configure the number of CPU cores and storage size that will apply to all worker nodes. Adjust the number of CPU cores and memory settings for your server group. To reset the requests and/or limits, pass in empty value."); export const coordinatorNodeConfigurationInformation = localize('arc.coordinatorNodeConfigurationInformation', "You can configure the number of CPU cores and storage size that will apply to the coordinator node. Adjust the number of CPU cores and memory settings for your server group. To reset the requests and/or limits, pass in empty value."); -export const workerNodesInformation = localize('arc.workerNodeInformation', "In preview it is not possible to reduce the number of worker nodes. Please refer to documentation linked above for more information."); +export const workerNodesInformation = localize('arc.workerNodeInformation', "It is possible to scale in and out your server group by reducing or increasing the number of worker nodes."); export const vCores = localize('arc.vCores', "vCores"); export const ram = localize('arc.ram', "RAM"); export const refresh = localize('arc.refresh', "Refresh"); diff --git a/extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts b/extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts index b96069937e..b4da2bd360 100644 --- a/extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts +++ b/extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts @@ -244,6 +244,7 @@ export class PostgresComputeAndStoragePage extends DashboardPage { // Worker node count this.workerCountBox = this.modelView.modelBuilder.inputBox().withProps({ readOnly: false, + min: 0, inputType: 'number', placeHolder: loc.loading, required: true @@ -544,7 +545,6 @@ export class PostgresComputeAndStoragePage extends DashboardPage { let scale = this._postgresModel.config?.spec.scale; this.currentConfiguration.workers = scale?.workers ?? scale?.shards ?? 0; - this.workerCountBox.min = this.currentConfiguration.workers; this.workerCountBox.placeHolder = ''; this.workerCountBox.value = this.currentConfiguration.workers.toString(); this.saveArgs.workers = undefined; diff --git a/extensions/azdata/src/azdata.ts b/extensions/azdata/src/azdata.ts index f3a44960fa..469c2f3bfc 100644 --- a/extensions/azdata/src/azdata.ts +++ b/extensions/azdata/src/azdata.ts @@ -151,7 +151,7 @@ export class AzdataTool implements azdataExt.IAzdataApi { if (args.port) { argsArray.push('--port', args.port.toString()); } if (args.replaceEngineSettings) { argsArray.push('--replace-engine-settings'); } if (args.workerEngineSettings) { argsArray.push('--worker-engine-settings', args.workerEngineSettings); } - if (args.workers) { argsArray.push('--workers', args.workers.toString()); } + if (args.workers !== undefined) { argsArray.push('--workers', args.workers.toString()); } return this.executeCommand(argsArray, additionalEnvVars, azdataContext); } }