Notebooks: Add Placeholder Cell, Fix Link Styling (#3728)

* Placeholder cell to add new real cells

* Fix links in notebooks to show correct color, rely on angular ngif for placeholder

* Fix failing test where one cell was expected by default

* Remove unnecessary TODO
This commit is contained in:
Chris LaFreniere
2019-01-14 17:29:06 -08:00
committed by GitHub
parent 6dc4096299
commit e0ceddce09
11 changed files with 140 additions and 20 deletions

View File

@@ -103,7 +103,7 @@ describe('notebook model', function(): void {
});
});
it('Should create single cell if model has no contents', async function(): Promise<void> {
it('Should create no cells if model has no contents', async function(): Promise<void> {
// Given an empty notebook
let emptyNotebook: nb.INotebookContents = {
cells: [],
@@ -125,9 +125,8 @@ describe('notebook model', function(): void {
let model = new NotebookModel(defaultModelOptions);
await model.requestModelLoad();
// Then I expect to have 1 code cell as the contents
should(model.cells).have.length(1);
should(model.cells[0].source).be.empty();
// Then I expect to have 0 code cell as the contents
should(model.cells).have.length(0);
});
it('Should throw if model load fails', async function(): Promise<void> {