From e16d3ed827161e6f071750370e9eea8837e3ac9b Mon Sep 17 00:00:00 2001 From: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Date: Fri, 11 Sep 2020 17:31:30 -0700 Subject: [PATCH] Address comments jupyter create book notebook (#12250) * Remove toc file link and add warning for windows users --- .../notebooks/JupyterBooksCreate.ipynb | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/extensions/notebook/resources/notebooks/JupyterBooksCreate.ipynb b/extensions/notebook/resources/notebooks/JupyterBooksCreate.ipynb index 737da9b89e..05c7ffb44b 100644 --- a/extensions/notebook/resources/notebooks/JupyterBooksCreate.ipynb +++ b/extensions/notebook/resources/notebooks/JupyterBooksCreate.ipynb @@ -24,9 +24,9 @@ "cell_type": "markdown", "source": [ "# Create Jupyter Book\n", - "This is a notebook to create a [Jupyter Book](https://jupyterbook.org/intro.html), which is an organized collections of Jupyter notebooks.\n", + " **Note**: **Windows users** using **Python 3.8** might be impacted by this known [issue](https://jupyterbook.org/advanced/advanced.html#working-on-windows) on the latest **jupyter book** version.\n", "\n", - " \n", + "This is a notebook to create a [Jupyter Book](https://jupyterbook.org/intro.html), which is an organized collections of Jupyter notebooks.\n", "\n", "The best way to use this notebook is by clicking Run all in the toolbar above. This will run all the cells in a step-by-step order so that you can create your Jupyter Book.\n", "\n", @@ -130,17 +130,16 @@ " elif version:\r\n", " if overwrite:\r\n", " shutil.rmtree(book_name)\r\n", - " else:\r\n", " # waiting for shutil to remove the directory\r\n", " while os.path.exists(book_name):\r\n", " pass\r\n", - " subprocess.check_call(['mkdir', book_name])\r\n", - " content_folder = os.path.join(content_folder,'')\r\n", - " if platform in ['linux', 'darwin']:\r\n", - " subprocess.check_call(['cp', '-r',content_folder, book_name])\r\n", - " else:\r\n", - " subprocess.check_call(['xcopy', content_folder, book_name])\r\n", - " !jupyter-book toc \"$book_name\"\r\n", + " os.mkdir(book_name)\r\n", + " content_folder = os.path.join(content_folder,'')\r\n", + " if platform in ['linux', 'darwin']:\r\n", + " subprocess.check_call(['cp', '-r',content_folder, book_name])\r\n", + " else:\r\n", + " subprocess.check_call(['xcopy', content_folder, book_name])\r\n", + " !jupyter-book toc \"$book_name\"\r\n", "except Exception as e:\r\n", " raise SystemExit(str(e))" ],