ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix selected state of select boxes (#19743)

Browse Source 
* fix the selected state

* add comments

* validate parameters
This commit is contained in:
Alan Ren
2022-06-15 20:41:07 -07:00
committed by GitHub
parent b980fe1106
commit e24f316ab7
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/vs/base/browser/ui/list/listWidget.ts
View File

@@ -1279,7 +1279,8 @@ export class List<T> implements ISpliceable<T>, IThemable, IDisposable {
private _options: IListOptions<T> = DefaultOptions
) {
const role = this._options.accessibilityProvider && this._options.accessibilityProvider.getWidgetRole ? this._options.accessibilityProvider?.getWidgetRole() : 'list';
this.selection = new SelectionTrait(role !== 'listbox');
// {{SQL CARBON EDIT}} - Change the parameter from 'role !== listbox' to 'role !== list', according to the doc https://www.w3.org/WAI/PF/HTML/wiki/RoleAttribute, list role is non-interactive.
this.selection = new SelectionTrait(role !== 'list');
mixin(_options, defaultStyles, false);

1
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
View File

@@ -271,6 +271,7 @@ export class SelectBoxList extends Disposable implements ISelectBoxDelegate, ILi
// Populate select list for non-native select mode
if (this.selectList) {
this.selectList.splice(0, this.selectList.length, this.options);
this.selectList?.setSelection(this.selected !== -1 ? [this.selected] : []); // {{SQL CARBON EDIT}} - Set the selected indexes.
}
}