ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-29 17:23:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bump azdataGraph version to 0.0.32 (#19954)

Browse Source 
* Update azdataGraph version to 0.0.31

* Adds icons

* Bumps azdataGraph version to 0.0.32

* Removes whitespace

* Uses icon that better adapts to color theme changes.

* Disables collapse for execution plans in plan comparison editor view
This commit is contained in:
Lewis Sanchez
2022-07-11 21:26:34 -07:00
committed by GitHub
parent 53a0388858
commit e25a9574a7
11 changed files with 29 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/contrib/executionPlan/browser/azdataGraphView.ts
View File

@@ -8,7 +8,7 @@ import * as azdata from 'azdata';
import * as sqlExtHostType from 'sql/workbench/api/common/sqlExtHostTypes';
import { ITextResourcePropertiesService } from 'vs/editor/common/services/textResourceConfigurationService';
import { isString } from 'vs/base/common/types';
import { badgeIconPaths, executionPlanNodeIconPaths } from 'sql/workbench/contrib/executionPlan/browser/constants';
import { badgeIconPaths, collapseExpandNodeIconPaths, executionPlanNodeIconPaths } from 'sql/workbench/contrib/executionPlan/browser/constants';
import { localize } from 'vs/nls';
import { Event, Emitter } from 'vs/base/common/event';
import { IColorTheme, ICssStyleCollector, registerThemingParticipant } from 'vs/platform/theme/common/themeService';
@@ -38,7 +38,7 @@ export class AzdataGraphView {
) {
this._parentContainer.tabIndex = 0;
this._diagramModel = this.populate(this._executionPlan.root);
this._diagram = new azdataGraph.azdataQueryPlan(this._parentContainer, this._diagramModel, executionPlanNodeIconPaths, badgeIconPaths);
this._diagram = new azdataGraph.azdataQueryPlan(this._parentContainer, this._diagramModel, executionPlanNodeIconPaths, badgeIconPaths, collapseExpandNodeIconPaths);
this.setGraphProperties();
this.selectElement(this._executionPlan.root);
this._cellInFocus = this._diagram.graph.getSelectionCell();
@@ -409,6 +409,10 @@ export class AzdataGraphView {
public clearSubtreePolygon(): void {
this._diagram.removeDrawnPolygons();
}
public disableNodeCollapse(disable: boolean): void {
this._diagram.disableNodeCollapse(disable);
}
}
export interface InternalExecutionPlanEdge extends azdata.executionPlan.ExecutionPlanEdge {

5
src/sql/workbench/contrib/executionPlan/browser/constants.ts
View File

@@ -257,6 +257,11 @@ export const badgeIconPaths = {
criticalWarning: imageBasePath + 'badge_critical_warning.svg'
};
export const collapseExpandNodeIconPaths = {
collapse: imageBasePath + 'collapse.svg',
expand: imageBasePath + 'expand.svg'
};
export const savePlanIconClassNames = 'ep-save-plan-icon';
export const openPropertiesIconClassNames = 'ep-open-properties-icon';
export const openQueryIconClassNames = 'ep-open-query-icon';

4
src/sql/workbench/contrib/executionPlan/browser/executionPlanComparisonEditorView.ts
View File

@@ -197,6 +197,8 @@ export class ExecutionPlanComparisonEditorView {
this._propertiesView.setTopElement(this._topPlanDiagramModels[e.index].root);
this._topPlanRecommendations.recommendations = this._topPlanDiagramModels[e.index].recommendations;
this._activeTopPlanIndex = e.index;
this._activeTopPlanDiagram.disableNodeCollapse(true);
await this.getSkeletonNodes();
});
attachSelectBoxStyler(this._topPlanDropdown, this.themeService);
@@ -223,6 +225,8 @@ export class ExecutionPlanComparisonEditorView {
this._propertiesView.setTopElement(this._bottomPlanDiagramModels[e.index].root);
this._bottomPlanRecommendations.recommendations = this._bottomPlanDiagramModels[e.index].recommendations;
this._activeBottomPlanIndex = e.index;
this._activeBottomPlanDiagram.disableNodeCollapse(true);
await this.getSkeletonNodes();
});
attachSelectBoxStyler(this._bottomPlanDropdown, this.themeService);

1
src/sql/workbench/contrib/executionPlan/browser/images/icons/collapse.svg Normal file
View File

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><style type="text/css">.icon-canvas-transparent{opacity:0;fill:#F6F6F6;} .icon-vs-out{fill:#F6F6F6;} .icon-vs-bg{fill:#424242;} .icon-vs-fg{fill:#F0EFF1;} .icon-vs-action-blue{fill:#00539C;}</style><path class="icon-canvas-transparent" d="M16 16h-16v-16h16v16z" id="canvas"/><path class="icon-vs-out" d="M14 2v12h-12v-12h12z" id="outline"/><path class="icon-vs-bg" d="M3 3v10h10v-10h-10zm9 9h-8v-8h8v8z" id="iconBg"/><path class="icon-vs-fg" d="M4 4v8h8v-8h-8zm7 5h-6v-2h6v2z" id="iconFg"/><path class="icon-vs-action-blue" d="M11 7v2h-6v-2h6z" id="colorAction"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 629 B

1
src/sql/workbench/contrib/executionPlan/browser/images/icons/expand.svg Normal file
View File

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><style type="text/css">.icon-canvas-transparent{opacity:0;fill:#F6F6F6;} .icon-vs-out{fill:#F6F6F6;} .icon-vs-bg{fill:#424242;} .icon-vs-fg{fill:#F0EFF1;} .icon-vs-action-blue{fill:#00539C;}</style><path class="icon-canvas-transparent" d="M16 16h-16v-16h16v16z" id="canvas"/><path class="icon-vs-out" d="M14 2v12h-12v-12h12z" id="outline"/><path class="icon-vs-bg" d="M3 3v10h10v-10h-10zm9 9h-8v-8h8v8z" id="iconBg"/><path class="icon-vs-fg" d="M4 4v8h8v-8h-8zm7 5h-2v2h-2v-2h-2v-2h2v-2h2v2h2v2z" id="iconFg"/><path class="icon-vs-action-blue" d="M11 7v2h-2v2h-2v-2h-2v-2h2v-2h2v2h2z" id="colorAction"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 669 B