From e31de8b1373f218ebe42e61cf7b4e9d926570b48 Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Wed, 3 Apr 2019 16:30:58 -0700 Subject: [PATCH] fixed more null references (#4841) --- .../base/browser/ui/scrollableSplitview/heightMap.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts b/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts index 0b6dedcd03..301864789e 100644 --- a/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts +++ b/src/sql/base/browser/ui/scrollableSplitview/heightMap.ts @@ -37,7 +37,7 @@ export class HeightMap { let totalSize: number; let sizeDiff = 0; - if (afterItemId === null) { + if (afterItemId === undefined) { i = 0; totalSize = 0; } else { @@ -201,12 +201,12 @@ export class HeightMap { return this.heightMap[index]; } - public itemAfter(item: IViewItem): IViewItem { - return this.heightMap[this.indexes[item.view.id] + 1] || null; + public itemAfter(item: IViewItem): IViewItem | undefined { + return this.heightMap[this.indexes[item.view.id] + 1] || undefined; } public dispose(): void { - this.heightMap = null; - this.indexes = null; + this.heightMap = undefined; + this.indexes = undefined; } }