ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-18 01:25:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

SQL-Migration extension - fix refresh reentrancy hang (#16482)

Browse Source 
* Fix application hang on refresh

* fix re-entrancy issue with refresh

* adding additional refresh checking
This commit is contained in:
brian-harris
2021-07-29 16:44:56 -07:00
committed by GitHub
parent 251d250523
commit e3c7e06983
4 changed files with 49 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/sql-migration/src/models/migrationLocalStorage.ts
View File

@@ -16,7 +16,7 @@ export class MigrationLocalStorage {
}
public static async getMigrationsBySourceConnections(connectionProfile: azdata.connection.ConnectionProfile, refreshStatus?: boolean): Promise<MigrationContext[]> {
const undefinedSessionId = '{undefined}';
const result: MigrationContext[] = [];
const validMigrations: MigrationContext[] = [];
@@ -32,7 +32,7 @@ export class MigrationLocalStorage {
migration.azureAccount,
migration.subscription,
migration.migrationContext,
migration.sessionId!
migration.sessionId ?? undefinedSessionId
);
migration.migrationContext.properties.sourceDatabaseName = sourceDatabase;
migration.migrationContext.properties.backupConfiguration = backupConfiguration;
@@ -41,7 +41,7 @@ export class MigrationLocalStorage {
migration.azureAccount,
migration.subscription,
migration.asyncUrl,
migration.sessionId!
migration.sessionId ?? undefinedSessionId
);
}
}