From e57acae79a75ba1c4e459efd5bbf97b502ab8086 Mon Sep 17 00:00:00 2001 From: Vasu Bhog Date: Mon, 15 Aug 2022 12:12:26 -0700 Subject: [PATCH] Add output channel for SQL Bindings extension (#20336) * add output channel for SQL Bindings extension * add output channel to open once added --- extensions/sql-bindings/src/common/azureFunctionsUtils.ts | 8 +++++++- extensions/sql-bindings/src/common/constants.ts | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/extensions/sql-bindings/src/common/azureFunctionsUtils.ts b/extensions/sql-bindings/src/common/azureFunctionsUtils.ts index 98948505b6..3ded71b3e9 100644 --- a/extensions/sql-bindings/src/common/azureFunctionsUtils.ts +++ b/extensions/sql-bindings/src/common/azureFunctionsUtils.ts @@ -25,6 +25,8 @@ export interface ILocalSettingsJson { ConnectionStrings?: { [key: string]: string }; } +export const outputChannel = vscode.window.createOutputChannel(constants.serviceName); + /** * copied and modified from vscode-azurefunctions extension * https://github.com/microsoft/vscode-azurefunctions/blob/main/src/funcConfig/local.settings.ts @@ -198,7 +200,11 @@ export async function getSettingsFile(projectFolder: string): Promise { - await utils.executeCommand(`dotnet add "${selectedProjectFile}" package ${constants.sqlExtensionPackageName} --prerelease`); + // clear the output channel prior to adding the nuget reference + outputChannel.clear(); + let addNugetCommmand = await utils.executeCommand(`dotnet add "${selectedProjectFile}" package ${constants.sqlExtensionPackageName} --prerelease`); + outputChannel.appendLine(constants.dotnetResult(addNugetCommmand)); + outputChannel.show(true); TelemetryReporter.sendActionEvent(TelemetryViews.CreateAzureFunctionWithSqlBinding, TelemetryActions.addSQLNugetPackage); } diff --git a/extensions/sql-bindings/src/common/constants.ts b/extensions/sql-bindings/src/common/constants.ts index f7ec2cc726..946bfd3b3e 100644 --- a/extensions/sql-bindings/src/common/constants.ts +++ b/extensions/sql-bindings/src/common/constants.ts @@ -22,6 +22,7 @@ export const sqlBindingsHelpLink = 'https://github.com/Azure/azure-functions-sql export const passwordPlaceholder = '******'; export const azureFunctionLocalSettingsFileName = 'local.settings.json'; export const vscodeOpenCommand = 'vscode.open'; +export const serviceName = 'SQL Bindings'; // localized constants export const functionNameTitle = localize('functionNameTitle', 'Function Name'); @@ -90,6 +91,7 @@ export function failedToParse(filename: string, error: any): string { return loc export function addSqlBinding(functionName: string): string { return localize('addSqlBinding', 'Adding SQL Binding to function "{0}"...'), functionName; } export function errorNewAzureFunction(error: any): string { return localize('errorNewAzureFunction', 'Error creating new Azure Function: {0}', utils.getErrorMessage(error)); } export function manuallyEnterObjectName(userObjectName: string): string { return `$(pencil) ${userObjectName}`; } +export function dotnetResult(output: string): string { return localize('dotnetResult', 'Adding SQL nuget package:\n{0}', output); } // Known Azure settings reference for Azure Functions // https://docs.microsoft.com/en-us/azure/azure-functions/functions-app-settings