ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add scan suppressions (#13705)

Browse Source
This commit is contained in:
Charles Gagnon
2020-12-07 13:31:59 -08:00
committed by GitHub
parent f96fd911c1
commit e59de59e61
4 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.config/CredScanSuppressions.json
View File

@@ -12,6 +12,10 @@
{ {
"file": "build\\actions\\AutoMerge\\dist\\index.js", "file": "build\\actions\\AutoMerge\\dist\\index.js",
"_justification": "False positive from webpacked code" "_justification": "False positive from webpacked code"
},
{
"file": ".devcontainer\\devcontainer.json",
"_justification": "Local development environment - not used in production"
} }
] ]
} }

6
extensions/arc/src/test/models/controllerModel.test.ts
View File

@@ -65,7 +65,7 @@ describe('ControllerModel', function (): void {
}); });
it('Prompt for password when not in cred store', async function (): Promise<void> { it('Prompt for password when not in cred store', async function (): Promise<void> {
const password = 'password123'; const password = 'password123'; // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Stub value for testing")]
// Set up cred store to return empty password // Set up cred store to return empty password
const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>(); const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>();
@@ -91,7 +91,7 @@ describe('ControllerModel', function (): void {
}); });
it('Prompt for password when rememberPassword is true but prompt reconnect is true', async function (): Promise<void> { it('Prompt for password when rememberPassword is true but prompt reconnect is true', async function (): Promise<void> {
const password = 'password123'; const password = 'password123'; // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Stub value for testing")]
// Set up cred store to return a password to start with // Set up cred store to return a password to start with
const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>(); const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>();
credProviderMock.setup(x => x.readCredential(TypeMoq.It.isAny())).returns(() => Promise.resolve({ credentialId: 'id', password: 'originalPassword' })); credProviderMock.setup(x => x.readCredential(TypeMoq.It.isAny())).returns(() => Promise.resolve({ credentialId: 'id', password: 'originalPassword' }));
@@ -117,7 +117,7 @@ describe('ControllerModel', function (): void {
}); });
it('Prompt for password when we already have a password but prompt reconnect is true', async function (): Promise<void> { it('Prompt for password when we already have a password but prompt reconnect is true', async function (): Promise<void> {
const password = 'password123'; const password = 'password123'; // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Stub value for testing")]
// Set up cred store to return a password to start with // Set up cred store to return a password to start with
const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>(); const credProviderMock = TypeMoq.Mock.ofType<azdata.CredentialProvider>();
credProviderMock.setup(x => x.readCredential(TypeMoq.It.isAny())).returns(() => Promise.resolve({ credentialId: 'id', password: 'originalPassword' })); credProviderMock.setup(x => x.readCredential(TypeMoq.It.isAny())).returns(() => Promise.resolve({ credentialId: 'id', password: 'originalPassword' }));

2
extensions/liveshare/src/guestSessionManager.ts
View File

@@ -60,7 +60,7 @@ export class GuestSessionManager {
connectionOptions['serverName'] = documentState.serverName; connectionOptions['serverName'] = documentState.serverName;
connectionOptions['databaseName'] = documentState.databaseName; connectionOptions['databaseName'] = documentState.databaseName;
connectionOptions['userName'] = 'liveshare'; connectionOptions['userName'] = 'liveshare';
connectionOptions['password'] = 'liveshare'; connectionOptions['password'] = 'liveshare'; // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Stub value for testing")]
connectionOptions['authenticationType'] = 'liveshare'; connectionOptions['authenticationType'] = 'liveshare';
connectionOptions['savePassword'] = false; connectionOptions['savePassword'] = false;
connectionOptions['saveProfile'] = false; connectionOptions['saveProfile'] = false;

2
extensions/liveshare/src/providers/statusProvider.ts
View File

@@ -40,7 +40,7 @@ export class StatusProvider {
connectionOptions['serverName'] = args.profile.options['server']; connectionOptions['serverName'] = args.profile.options['server'];
connectionOptions['databaseName'] = args.profile.options['database']; connectionOptions['databaseName'] = args.profile.options['database'];
connectionOptions['userName'] = 'liveshare'; connectionOptions['userName'] = 'liveshare';
connectionOptions['password'] = 'liveshare'; connectionOptions['password'] = 'liveshare'; // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Stub value for testing")]
connectionOptions['authenticationType'] = 'liveshare'; connectionOptions['authenticationType'] = 'liveshare';
connectionOptions['savePassword'] = false; connectionOptions['savePassword'] = false;
connectionOptions['saveProfile'] = false; connectionOptions['saveProfile'] = false;