ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-03-20 03:51:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

Enabling Database scoped configurations tab to DB Properties (#23890)

Browse Source 
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* using the existed setTableData method

* code review comment updates

* Input type checkbox update table additional validation

* fixing the input type focus and reverting the enterKeyPress logic

* fixing the flickering issue with data refresh

* moving code inline and using actual component

* cleanup

* addressing code review comments

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch
This commit is contained in:
Sai Avishkar Sreerama
2023-08-16 12:00:18 -05:00
committed by GitHub
parent f1ba6baf41
commit e5b7bff7b4
6 changed files with 419 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/mssql/src/objectManagement/localizedConstants.ts
View File

@@ -310,7 +310,11 @@ export const DatabaseReadOnlyText = localize('objectManagement.databasePropertie
export const DatabaseStateText = localize('objectManagement.databaseProperties.databaseStateText', "Database State");
export const EncryptionEnabledText = localize('objectManagement.databaseProperties.encryptionEnabledText', "Encryption Enabled");
export const RestrictAccessText = localize('objectManagement.databaseProperties.restrictAccessText', "Restrict Access");
export const DatabaseScopedConfigurationTabHeader = localize('objectManagement.databaseProperties.databaseProperties.databaseScopedConfigurationTabHeader', "Database Scoped Configuration");
export const DatabaseScopedOptionsColumnHeader = localize('objectManagement.databaseProperties.databaseScopedOptionsColumnHeader', "Database Scoped Options");
export const ValueForPrimaryColumnHeader = localize('objectManagement.databaseProperties.valueForPrimaryColumnHeader', "Value for Primary");
export const ValueForSecondaryColumnHeader = localize('objectManagement.databaseProperties.valueForSecondaryColumnHeader', "Value for Secondary");
export const SetSecondaryText = localize('objectManagement.databaseProperties.setSecondaryText', "Set Secondary same as Primary");
// Util functions
export function getNodeTypeDisplayName(type: string, inTitle: boolean = false): string {