ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #2523

Browse Source 
The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden.

The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track.

Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this.
This commit is contained in:
Kevin Cunnane
2018-09-11 16:36:17 -07:00
parent 8ec09d25ce
commit e63bb6a8ec
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/parts/modelComponents/componentWithIconBase.ts
View File

@@ -22,6 +22,8 @@ export class ItemDescriptor<T> {
constructor(public descriptor: IComponentDescriptor, public config: T) { } constructor(public descriptor: IComponentDescriptor, public config: T) { }
} }
const ids = new IdGenerator('model-view-component-icon-');
export abstract class ComponentWithIconBase extends ComponentBase { export abstract class ComponentWithIconBase extends ComponentBase {
protected _iconClass: string; protected _iconClass: string;
@@ -42,7 +44,6 @@ export abstract class ComponentWithIconBase extends ComponentBase {
if (this.iconPath && this.iconPath !== this._iconPath) { if (this.iconPath && this.iconPath !== this._iconPath) {
this._iconPath = this.iconPath; this._iconPath = this.iconPath;
if (!this._iconClass) { if (!this._iconClass) {
const ids = new IdGenerator('model-view-component-icon-' + Math.round(Math.random() * 1000));
this._iconClass = ids.nextId(); this._iconClass = ids.nextId();
} }