From e672fbf6e281777c7bd61ce57dfa63cf2351198d Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Fri, 5 Oct 2018 11:25:28 -0700 Subject: [PATCH] change selection on header selection to provide 1 selection not 1 million (#2757) --- .../browser/ui/table/plugins/additionalKeyBindings.plugin.ts | 2 -- .../base/browser/ui/table/plugins/rowNumberColumn.plugin.ts | 5 +++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/sql/base/browser/ui/table/plugins/additionalKeyBindings.plugin.ts b/src/sql/base/browser/ui/table/plugins/additionalKeyBindings.plugin.ts index 5711f8c049..35d7e318bb 100644 --- a/src/sql/base/browser/ui/table/plugins/additionalKeyBindings.plugin.ts +++ b/src/sql/base/browser/ui/table/plugins/additionalKeyBindings.plugin.ts @@ -56,8 +56,6 @@ export class AdditionalKeyBindings implements Slick.Plugin { let selectionModel = this.grid.getSelectionModel(); if (selectionModel) { selectionModel.setSelectedRanges([new Slick.Range(0, 0, this.grid.getDataLength() - 1, this.grid.getColumns().length - 1)]); - } else { - this.grid.setSelectedRows(range(this.grid.getDataLength())); } } else { handled = false; diff --git a/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts b/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts index 7806e083f4..547dcd15f3 100644 --- a/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts +++ b/src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts @@ -45,8 +45,9 @@ export class RowNumberColumn implements Slick.Plugin { private handleHeaderClick(e: MouseEvent, args: Slick.OnHeaderClickEventArgs): void { if (args.column.id === 'rowNumber') { this.grid.setActiveCell(0, 1); - if (this.grid.getSelectionModel()) { - this.grid.setSelectedRows(range(this.grid.getDataLength())); + let selectionModel = this.grid.getSelectionModel(); + if (selectionModel) { + selectionModel.setSelectedRanges([new Slick.Range(0, 0, this.grid.getDataLength() - 1, this.grid.getColumns().length - 1)]); } } }