diff --git a/src/sql/parts/modelComponents/button.component.ts b/src/sql/parts/modelComponents/button.component.ts index b32b075662..4b0bd413f9 100644 --- a/src/sql/parts/modelComponents/button.component.ts +++ b/src/sql/parts/modelComponents/button.component.ts @@ -93,10 +93,10 @@ export default class ButtonComponent extends ComponentBase implements IComponent this._button.enabled = this.enabled; this._button.label = this.label; if (this.width) { - this._button.setWidth(this.width.toString()); + this._button.setWidth(this.convertSize(this.width.toString())); } if (this.height) { - this._button.setWidth(this.height.toString()); + this._button.setWidth(this.convertSize(this.height.toString())); } this.updateIcon(); } diff --git a/src/sql/parts/modelComponents/checkbox.component.ts b/src/sql/parts/modelComponents/checkbox.component.ts index c0f894b065..593f872cf5 100644 --- a/src/sql/parts/modelComponents/checkbox.component.ts +++ b/src/sql/parts/modelComponents/checkbox.component.ts @@ -20,7 +20,7 @@ import { attachInputBoxStyler, attachListStyler } from 'vs/platform/theme/common @Component({ selector: 'modelview-checkbox', template: ` -
+ ` }) export default class CheckBoxComponent extends ComponentBase implements IComponent, OnDestroy, AfterViewInit { diff --git a/src/sql/parts/modelComponents/componentBase.ts b/src/sql/parts/modelComponents/componentBase.ts index c812f34272..c60fbbc32c 100644 --- a/src/sql/parts/modelComponents/componentBase.ts +++ b/src/sql/parts/modelComponents/componentBase.ts @@ -146,11 +146,12 @@ export abstract class ComponentBase extends Disposable implements IComponent, On return this.height ? this.convertSize(this.height) : ''; } - protected convertSize(size: number | string): string { + protected convertSize(size: number | string, defaultValue?: string): string { + defaultValue = defaultValue || ''; if (types.isUndefinedOrNull(size)) { - return '100%'; + return defaultValue; } - let convertedSize: string = size ? size.toString() : '100%'; + let convertedSize: string = size ? size.toString() : defaultValue; if (!convertedSize.toLowerCase().endsWith('px') && !convertedSize.toLowerCase().endsWith('%')) { convertedSize = convertedSize + 'px'; } diff --git a/src/sql/parts/modelComponents/dropdown.component.ts b/src/sql/parts/modelComponents/dropdown.component.ts index 2f3f2788fa..4049aaac8a 100644 --- a/src/sql/parts/modelComponents/dropdown.component.ts +++ b/src/sql/parts/modelComponents/dropdown.component.ts @@ -145,18 +145,26 @@ export default class DropDownComponent extends ComponentBase implements ICompone } private getSelectedValue(): string { - if (this.values && this.valuesHaveDisplayName()) { - let valueCategory = (