ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Swallow error on context view when disposing children (#1663)

Browse Source 
* swallow error on context view  when disposing children

* fix edit comment
This commit is contained in:
Anthony Dresser
2018-06-19 12:22:25 -07:00
committed by GitHub
parent 520cfb780a
commit e69158d9b2
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
View File

@@ -397,8 +397,16 @@ export class SelectBoxList implements ISelectBoxDelegate, IDelegate<ISelectOptio
container.appendChild(this.selectDropDownContainer); container.appendChild(this.selectDropDownContainer);
this.layoutSelectDropDown(); this.layoutSelectDropDown();
// {{SQL CARBON EDIT}}
return { return {
dispose: () => container.removeChild(this.selectDropDownContainer) // remove to take out the CSS rules we add dispose: () => {
try {
container.removeChild(this.selectDropDownContainer); // remove to take out the CSS rules we add
} catch(e) {
// if this fails it means it is already removed
}
}
}; };
} }