From e74538b40ddc6d2c401fb9e14194f8780c67a2d2 Mon Sep 17 00:00:00 2001 From: Alex Ma Date: Tue, 15 Oct 2019 14:29:34 -0700 Subject: [PATCH] Added notification for unsaved file in scheduling (#7705) * Added notification for unsaved file in scheduling * Removed logging message in line 216 * Changed regex for all 3 platforms (forbid '/') * Untitled file prompts to save in mainController * removed spaces and changed save message --- extensions/agent/src/mainController.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/agent/src/mainController.ts b/extensions/agent/src/mainController.ts index d5b52eb822..78512b8918 100644 --- a/extensions/agent/src/mainController.ts +++ b/extensions/agent/src/mainController.ts @@ -169,8 +169,8 @@ export class MainController { if (!ownerUri || ownerUri instanceof vscode.Uri) { let path: string; if (!ownerUri) { - if (azdata.nb.activeNotebookEditor.document.isDirty) { - vscode.window.showErrorMessage(localize('agent.unsavedFileSchedulingError', 'Save file before scheduling'), { modal: true }); + if (azdata.nb.activeNotebookEditor.document.isDirty || azdata.nb.activeNotebookEditor.document.isUntitled) { + vscode.window.showErrorMessage(localize('agent.unsavedFileSchedulingError', 'The notebook must be saved before being scheduled. Please save and then retry scheduling again.'), { modal: true }); return; } path = azdata.nb.activeNotebookEditor.document.fileName;