ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixing migration private preview bugs WIP 3 (#14928)

Browse Source 
* Adding server name to wizard and dialog title
Surfacing async errors
Fixing a bunch of strings to match the mockup

* Adding auto refresh for migration status

* Removing errors for sql vm migration

* using new logic to get sql server username

* Fixing help links

* Removing unncessary await
This commit is contained in:
Aasim Khan
2021-03-31 10:19:59 -07:00
committed by GitHub
parent 00d2fadb7d
commit e762f19815
18 changed files with 198 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/sql-migration/src/wizard/skuRecommendationPage.ts
View File

@@ -64,7 +64,7 @@ export class SKURecommendationPage extends MigrationWizardPage {
this._view = view;
this._igComponent = this.createStatusComponent(view); // The first component giving basic information
this._detailsComponent = this.createDetailsComponent(view); // The details of what can be moved
this._chooseTargetComponent = this.createChooseTargetComponent(view);
this._chooseTargetComponent = await this.createChooseTargetComponent(view);
this._azureSubscriptionText = this.createAzureSubscriptionText(view);
@@ -223,7 +223,7 @@ export class SKURecommendationPage extends MigrationWizardPage {
return component;
}
private createChooseTargetComponent(view: azdata.ModelView): azdata.DivContainer {
private async createChooseTargetComponent(view: azdata.ModelView): Promise<azdata.DivContainer> {
this._rbg = this._view!.modelBuilder.radioCardGroup().withProps({
cards: [],
@@ -279,8 +279,10 @@ export class SKURecommendationPage extends MigrationWizardPage {
descriptions
});
});
let miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE, this, MigrationTargetType.SQLMI);
let vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE, this, MigrationTargetType.SQLVM);
const serverName = (await this.migrationStateModel.getSourceConnectionProfile()).serverName;
let miDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(serverName), this, MigrationTargetType.SQLMI);
let vmDialog = new AssessmentResultsDialog('ownerUri', this.migrationStateModel, constants.ASSESSMENT_TILE(serverName), this, MigrationTargetType.SQLVM);
this._rbg.onLinkClick(async (value) => {
if (value.cardId === MigrationTargetType.SQLVM) {