mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-02-15 10:58:31 -05:00
Merge from vscode merge-base (#22780)
* Revert "Revert "Merge from vscode merge-base (#22769)" (#22779)"
This reverts commit 47a1745180.
* Fix notebook download task
* Remove done call from extensions-ci
This commit is contained in:
@@ -19,7 +19,7 @@ export interface IElectronConfiguration {
|
||||
}
|
||||
|
||||
export async function resolveElectronConfiguration(options: LaunchOptions): Promise<IElectronConfiguration> {
|
||||
const { codePath, workspacePath, extensionsPath, userDataDir, remote, logger, logsPath, extraArgs } = options;
|
||||
const { codePath, workspacePath, extensionsPath, userDataDir, remote, logger, logsPath, crashesPath, extraArgs } = options;
|
||||
const env = { ...process.env };
|
||||
|
||||
const args = [
|
||||
@@ -30,7 +30,7 @@ export async function resolveElectronConfiguration(options: LaunchOptions): Prom
|
||||
'--no-cached-data',
|
||||
'--disable-updates',
|
||||
'--disable-keytar',
|
||||
'--disable-crash-reporter',
|
||||
`--crash-reporter-directory=${crashesPath}`,
|
||||
'--disable-workspace-trust',
|
||||
`--extensions-dir=${extensionsPath}`,
|
||||
`--user-data-dir=${userDataDir}`,
|
||||
@@ -42,7 +42,11 @@ export async function resolveElectronConfiguration(options: LaunchOptions): Prom
|
||||
}
|
||||
|
||||
if (process.platform === 'linux') {
|
||||
args.push('--disable-gpu'); // Linux has trouble in VMs to render properly with GPU enabled
|
||||
// --disable-dev-shm-usage: when run on docker containers where size of /dev/shm
|
||||
// partition < 64MB which causes OOM failure for chromium compositor that uses
|
||||
// this partition for shared memory.
|
||||
// Refs https://github.com/microsoft/vscode/issues/152143
|
||||
args.push('--disable-dev-shm-usage');
|
||||
}
|
||||
|
||||
if (remote) {
|
||||
|
||||
Reference in New Issue
Block a user