From e7f976323715e5aa6aa67e499ed381d7f988e4a6 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Fri, 27 Jan 2023 13:22:16 -0800 Subject: [PATCH] fix undefined error in dacpac extension when sending telemetry (#21727) * fix undefined error in dacpac extension when sending telemetry * update interface --- extensions/dacpac/src/wizard/api/models.ts | 2 +- extensions/dacpac/src/wizard/dataTierApplicationWizard.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/dacpac/src/wizard/api/models.ts b/extensions/dacpac/src/wizard/api/models.ts index 7624070c27..dd6113ceb6 100644 --- a/extensions/dacpac/src/wizard/api/models.ts +++ b/extensions/dacpac/src/wizard/api/models.ts @@ -16,5 +16,5 @@ export interface DacFxDataModel { filePath: string; version: string; upgradeExisting: boolean; - potentialDataLoss: boolean; + potentialDataLoss?: boolean; } diff --git a/extensions/dacpac/src/wizard/dataTierApplicationWizard.ts b/extensions/dacpac/src/wizard/dataTierApplicationWizard.ts index 94bae415f1..3ed5c4f3c4 100644 --- a/extensions/dacpac/src/wizard/dataTierApplicationWizard.ts +++ b/extensions/dacpac/src/wizard/dataTierApplicationWizard.ts @@ -335,7 +335,7 @@ export class DataTierApplicationWizard { additionalMeasurements.totalDurationMs = (new Date().getTime() - deployStartTime); additionalMeasurements.deployDacpacFileSizeBytes = await utils.tryGetFileSize(this.model.filePath); additionalProps.upgradeExistingDatabase = this.model.upgradeExisting.toString(); - additionalProps.potentialDataLoss = this.model.potentialDataLoss.toString(); + additionalProps.potentialDataLoss = this.model.potentialDataLoss?.toString(); this.sendDacFxOperationTelemetryEvent(result, TelemetryAction.DeployDacpac, additionalProps, additionalMeasurements);