ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removed localization from error messages (#21085)

Browse Source 
* removed localization from error messages

* use logger

* localize message displayed to user
This commit is contained in:
Christopher Suh
2022-11-02 18:17:59 -07:00
committed by GitHub
parent dc5f7854a2
commit e87995527b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/azurecore/src/azureResource/services/subscriptionService.ts
View File

@@ -11,6 +11,7 @@ import { IAzureResourceSubscriptionService } from '../interfaces';
import { TokenCredentials } from '@azure/ms-rest-js'; import { TokenCredentials } from '@azure/ms-rest-js';
import { AzureSubscriptionError } from '../errors'; import { AzureSubscriptionError } from '../errors';
import { AzureResourceErrorMessageUtil } from '../utils'; import { AzureResourceErrorMessageUtil } from '../utils';
import { Logger } from '../../utils/Logger';
import * as nls from 'vscode-nls'; import * as nls from 'vscode-nls';
const localize = nls.loadMessageBundle(); const localize = nls.loadMessageBundle();
@@ -45,12 +46,12 @@ export class AzureResourceSubscriptionService implements IAzureResourceSubscript
} }
else if (!account.isStale) { else if (!account.isStale) {
const errorMsg = localize('azure.resource.tenantTokenError', "Failed to acquire Access Token for account '{0}' (tenant '{1}').", account.displayInfo.displayName, tenantId); const errorMsg = localize('azure.resource.tenantTokenError', "Failed to acquire Access Token for account '{0}' (tenant '{1}').", account.displayInfo.displayName, tenantId);
console.warn(errorMsg); Logger.error(`Failed to acquire Access Token for account '${account.displayInfo.displayName}' (tenant '${tenantId}').`);
void vscode.window.showWarningMessage(errorMsg); void vscode.window.showWarningMessage(errorMsg);
} }
} catch (error) { } catch (error) {
const errorMsg = localize('azure.resource.tenantSubscriptionsError', "Failed to get subscriptions for account {0} (tenant '{1}'). {2}", account.displayInfo.displayName, tenantId, AzureResourceErrorMessageUtil.getErrorMessage(error)); const errorMsg = localize('azure.resource.tenantSubscriptionsError', "Failed to get subscriptions for account {0} (tenant '{1}'). {2}", account.displayInfo.displayName, tenantId, AzureResourceErrorMessageUtil.getErrorMessage(error));
console.warn(errorMsg); Logger.error(`Failed to get subscriptions for account ${account.displayInfo.displayName} (tenant '${tenantId}'). ${AzureResourceErrorMessageUtil.getErrorMessage(error)}`);
errors.push(error); errors.push(error);
void vscode.window.showWarningMessage(errorMsg); void vscode.window.showWarningMessage(errorMsg);
} }