Initial Code Layering (#3788)

* working on formatting

* fixed basic lint errors; starting moving things to their appropriate location

* formatting

* update tslint to match the version of vscode we have

* remove unused code

* work in progress fixing layering

* formatting

* moved connection management service to platform

* formatting

* add missing file

* moving more servies

* formatting

* moving more services

* formatting

* wip

* moving more services

* formatting

* revert back tslint rules

* move css file

* add missing svgs
This commit is contained in:
Anthony Dresser
2019-01-25 14:52:35 -08:00
committed by GitHub
parent c8986464ec
commit ea67859de7
338 changed files with 2036 additions and 7386 deletions

View File

@@ -72,7 +72,7 @@ export class PlanNode {
indexObject: IndexObject;
public addChildren(children: PlanNode[]): void {
if(children) {
if (children) {
children.forEach(element => {
element.parent = this;
});
@@ -198,7 +198,7 @@ export class PlanXmlParser {
return undefined;
}
for (var index = 0; index < element.childNodes.length; index++) {
for (let index = 0; index < element.childNodes.length; index++) {
if (element.childNodes[index].nodeName.toLocaleLowerCase() === elementName.toLocaleLowerCase()) {
elements = elements.concat(element.children[index]);
}
@@ -206,13 +206,13 @@ export class PlanXmlParser {
if (elements.length > 0) {
return elements;
}
for (var index = 0; index < element.childNodes.length; index++) {
for (let index = 0; index < element.childNodes.length; index++) {
if (untilNode && element.childNodes[index].nodeName === untilNode) {
continue;
}
let result = this.findChildren(element.children[index], elementName, untilNode);
if (result !== undefined) {
return result;
return result;
}
}
@@ -224,7 +224,7 @@ export class PlanXmlParser {
let children = this.findChildren(element, elementName);
if (children) {
for (var index = 0; index < children.length; index++) {
for (let index = 0; index < children.length; index++) {
let childNode = children[index];
let planNode = this.convertToPlanNode(childNode);
@@ -285,8 +285,8 @@ export class PlanXmlParser {
}
private findAttribute(attributes: NamedNodeMap, attName: string): any {
for (var index = 0; index < attributes.length; index++) {
var attribute = attributes[index];
for (let index = 0; index < attributes.length; index++) {
let attribute = attributes[index];
if (attribute.name === attName) {
return attribute.value;
}

View File

@@ -11,11 +11,11 @@ import { BaseEditor } from 'vs/workbench/browser/parts/editor/baseEditor';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { IThemeService } from 'vs/platform/theme/common/themeService';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { QueryPlanInput } from './queryPlanInput';
import { QueryPlanModule } from './queryPlan.module';
import { IConnectionManagementService } from 'sql/parts/connection/common/connectionManagement';
import { IMetadataService } from 'sql/services/metadata/metadataService';
import { IScriptingService } from 'sql/services/scripting/scriptingService';
import { QueryPlanInput } from 'sql/parts/queryPlan/queryPlanInput';
import { QueryPlanModule } from 'sql/parts/queryPlan/queryPlan.module';
import { IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
import { IMetadataService } from 'sql/platform/metadata/common/metadataService';
import { IScriptingService } from 'sql/platform/scripting/common/scriptingService';
import { IQueryEditorService } from 'sql/parts/query/common/queryEditorService';
import { bootstrapAngular } from 'sql/services/bootstrap/bootstrapService';
import { IQueryPlanParams } from 'sql/services/bootstrap/bootstrapParams';

View File

@@ -6,8 +6,8 @@
import { TPromise } from 'vs/base/common/winjs.base';
import { EditorInput, EditorModel } from 'vs/workbench/common/editor';
import { UntitledEditorInput } from 'vs/workbench/common/editor/untitledEditorInput';
import { IConnectionProfile } from 'sql/parts/connection/common/interfaces';
import { ConnectionManagementInfo } from 'sql/parts/connection/common/connectionManagementInfo';
import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
import { ConnectionManagementInfo } from 'sql/platform/connection/common/connectionManagementInfo';
export class QueryPlanInput extends EditorInput {
@@ -55,7 +55,7 @@ export class QueryPlanInput extends EditorInput {
public get hasInitialized(): boolean {
return !!this._uniqueSelector;
}
}
public get uniqueSelector(): string {
return this._uniqueSelector;

View File

@@ -13,7 +13,7 @@ import { attachTableStyler } from 'sql/common/theme/styler';
import { IQueryComponentParams } from 'sql/services/bootstrap/bootstrapParams';
import * as GridContentEvents from 'sql/parts/grid/common/gridContentEvents';
import { DataService } from 'sql/parts/grid/services/dataService';
import { toDisposableSubscription } from 'sql/parts/common/rxjsUtils';
import { toDisposableSubscription } from 'sql/base/node/rxjsUtils';
import { localize } from 'vs/nls';
import { IDisposable, dispose } from 'vs/base/common/lifecycle';