Initial Code Layering (#3788)

* working on formatting

* fixed basic lint errors; starting moving things to their appropriate location

* formatting

* update tslint to match the version of vscode we have

* remove unused code

* work in progress fixing layering

* formatting

* moved connection management service to platform

* formatting

* add missing file

* moving more servies

* formatting

* moving more services

* formatting

* wip

* moving more services

* formatting

* revert back tslint rules

* move css file

* add missing svgs

src/sql/workbench/common/actions.ts

@@ -3,21 +3,21 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { IConnectionManagementService, IErrorMessageService } from 'sql/parts/connection/common/connectionManagement';
-import * as TaskUtilities from './taskUtilities';
+import { IConnectionManagementService } from 'sql/platform/connection/common/connectionManagement';
+import * as TaskUtilities from 'sql/workbench/common/taskUtilities';
 import { IQueryEditorService } from 'sql/parts/query/common/queryEditorService';
-import { IConnectionProfile } from 'sql/parts/connection/common/interfaces';
+import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import { IInsightsConfig } from 'sql/parts/dashboard/widgets/insights/interfaces';
-import { IScriptingService } from 'sql/services/scripting/scriptingService';
-import { IRestoreDialogController } from 'sql/parts/disasterRecovery/restore/common/restoreService';
-import { IBackupUiService } from 'sql/parts/disasterRecovery/backup/common/backupService';
-import { IAngularEventingService, AngularEventType } from 'sql/services/angularEventing/angularEventingService';
+import { IScriptingService } from 'sql/platform/scripting/common/scriptingService';
+import { IRestoreDialogController } from 'sql/platform/restore/common/restoreService';
+import { IBackupUiService } from 'sql/platform/backup/common/backupService';
+import { IAngularEventingService, AngularEventType } from 'sql/platform/angularEventing/common/angularEventingService';
 import { IInsightsDialogService } from 'sql/parts/insights/common/interfaces';
-import { IAdminService } from 'sql/parts/admin/common/adminService';
+import { IAdminService } from 'sql/workbench/services/admin/common/adminService';
 import * as Constants from 'sql/common/constants';
-import { ScriptOperation } from 'sql/workbench/common/taskUtilities';
 import { Task } from 'sql/platform/tasks/common/tasks';
 import { IObjectExplorerService } from 'sql/parts/objectExplorer/common/objectExplorerService';
+import { IErrorMessageService } from 'sql/platform/errorMessage/common/errorMessageService';
 
 import { ObjectMetadata } from 'sqlops';
 
@@ -132,7 +132,7 @@ export class ScriptExecuteAction extends Action {
 				this._connectionManagementService,
 				this._queryEditorService,
 				this._scriptingService,
-				ScriptOperation.Execute,
+				TaskUtilities.ScriptOperation.Execute,
 				this._errorMessageService
 			).then(
 				result => {
@@ -168,7 +168,7 @@ export class ScriptAlterAction extends Action {
 				this._connectionManagementService,
 				this._queryEditorService,
 				this._scriptingService,
-				ScriptOperation.Alter,
+				TaskUtilities.ScriptOperation.Alter,
 				this._errorMessageService
 			).then(
 				result => {
@@ -237,7 +237,7 @@ export class ScriptCreateAction extends Action {
 				this._connectionManagementService,
 				this._queryEditorService,
 				this._scriptingService,
-				ScriptOperation.Create,
+				TaskUtilities.ScriptOperation.Create,
 				this._errorMessageService
 			).then(
 				result => {
@@ -273,7 +273,7 @@ export class ScriptDeleteAction extends Action {
 				this._connectionManagementService,
 				this._queryEditorService,
 				this._scriptingService,
-				ScriptOperation.Delete,
+				TaskUtilities.ScriptOperation.Delete,
 				this._errorMessageService
 			).then(
 				result => {

src/sql/workbench/common/sqlWorkbenchUtils.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 'use strict';
 
-import ConnectionConstants = require('sql/parts/connection/common/constants');
+import ConnectionConstants = require('sql/platform/connection/common/constants');
 import { QueryInput } from 'sql/parts/query/common/queryInput';
 
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';

src/sql/workbench/common/taskUtilities.ts

@@ -4,31 +4,35 @@
  *--------------------------------------------------------------------------------------------*/
 'use strict';
 
-import { IConnectionProfile } from 'sql/parts/connection/common/interfaces';
+import * as os from 'os';
+
+import { IConnectionProfile } from 'sql/platform/connection/common/interfaces';
 import {
 	IConnectableInput, IConnectionManagementService,
-	IConnectionCompletionOptions, ConnectionType, IErrorMessageService,
+	IConnectionCompletionOptions, ConnectionType,
 	RunQueryOnConnectionMode, IConnectionResult
-} from 'sql/parts/connection/common/connectionManagement';
+} from 'sql/platform/connection/common/connectionManagement';
 import { IQueryEditorService } from 'sql/parts/query/common/queryEditorService';
-import { IScriptingService } from 'sql/services/scripting/scriptingService';
+import { IScriptingService } from 'sql/platform/scripting/common/scriptingService';
 import { EditDataInput } from 'sql/parts/editData/common/editDataInput';
-import { IAdminService } from 'sql/parts/admin/common/adminService';
-import { IRestoreDialogController } from 'sql/parts/disasterRecovery/restore/common/restoreService';
-import { IBackupUiService } from 'sql/parts/disasterRecovery/backup/common/backupService';
+import { IAdminService } from 'sql/workbench/services/admin/common/adminService';
+import { IRestoreDialogController } from 'sql/platform/restore/common/restoreService';
+import { IBackupUiService } from 'sql/platform/backup/common/backupService';
 import { IInsightsConfig } from 'sql/parts/dashboard/widgets/insights/interfaces';
 import { IInsightsDialogService } from 'sql/parts/insights/common/interfaces';
-import { ConnectionManagementInfo } from 'sql/parts/connection/common/connectionManagementInfo';
-import Severity from 'vs/base/common/severity';
-import * as sqlops from 'sqlops';
-import nls = require('vs/nls');
-import os = require('os');
-import path = require('path');
+import { ConnectionManagementInfo } from 'sql/platform/connection/common/connectionManagementInfo';
 import { IObjectExplorerService } from 'sql/parts/objectExplorer/common/objectExplorerService';
-import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import { QueryInput } from 'sql/parts/query/common/queryInput';
 import { DashboardInput } from 'sql/parts/dashboard/dashboardInput';
 import { ProfilerInput } from 'sql/parts/profiler/editor/profilerInput';
+import { IErrorMessageService } from 'sql/platform/errorMessage/common/errorMessageService';
+
+import * as sqlops from 'sqlops';
+
+import Severity from 'vs/base/common/severity';
+import * as nls from 'vs/nls';
+import * as path from 'vs/base/common/paths';
+import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 
 // map for the version of SQL Server (default is 140)
 const scriptCompatibilityOptionMap = {