ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where select box selection could not be changed by mouse (#1616)

Browse Source
This commit is contained in:
Matt Irvine
2018-06-12 14:48:58 -07:00
committed by GitHub
parent d39ceffa94
commit eaf1e08752
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
View File

@@ -541,21 +541,22 @@ export class SelectBoxList implements ISelectBoxDelegate, IDelegate<ISelectOptio
this.selectList.setFocus([this.selected]); this.selectList.setFocus([this.selected]);
this.selectList.reveal(this.selectList.getFocus()[0]); this.selectList.reveal(this.selectList.getFocus()[0]);
// {{SQL CARBON EDIT}} - Update the selection before firing the handler instead of after
// Reset Selection Handler
this._currentSelection = -1;
this.hideSelectDropDown(true);
this._onDidSelect.fire({ this._onDidSelect.fire({
index: this.selectElement.selectedIndex, index: this.selectElement.selectedIndex,
selected: this.selectElement.title selected: this.selectElement.title
}); });
// Reset Selection Handler
this._currentSelection = -1;
this.hideSelectDropDown(true);
} }
dom.EventHelper.stop(e); dom.EventHelper.stop(e);
} }
// List Exit - passive - hide drop-down, fire onDidSelect // List Exit - passive - hide drop-down, fire onDidSelect
private onListBlur(): void { private onListBlur(): void {
if (this._currentSelection >= 0) { if (this._currentSelection >= 0) {
this.select(this._currentSelection); this.select(this._currentSelection);
} }