From ebd4c6844bb65a9928905ce6ed960d194d973529 Mon Sep 17 00:00:00 2001 From: Christopher Suh Date: Mon, 28 Feb 2022 18:20:12 -0800 Subject: [PATCH] Update CI for new windows-latest (#18585) * change to windows-2019 * fix for windows-latest --- .github/workflows/ci.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 220ef10547..5bf9ba30a3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -59,7 +59,14 @@ jobs: env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 ELECTRON_SKIP_BINARY_DOWNLOAD: 1 - run: yarn --frozen-lockfile --network-timeout 180000 + run: | + # update node-gyp to latest for support in detecting VS 2022 toolchain + npm install -g node-gyp@latest + # Resolve to node-gyp.js + # Remove this once node-version > 17.4.x or > 16.14.0, + # which ships with npm > 8.4.0 that has support for VS 2022 toolchain. + $env:npm_config_node_gyp=$(Join-Path $(Get-Command node-gyp.cmd).Path "..\node_modules\node-gyp\bin\node-gyp.js" -Resolve) + yarn --frozen-lockfile --network-timeout 180000 # - name: Create node_modules archive {{SQL CARBON EDIT}} Skip caching for now # if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }} # run: |