ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix scan hits (#16788)

Browse Source
This commit is contained in:
Charles Gagnon
2021-08-16 12:59:18 -07:00
committed by GitHub
parent 455b3478c1
commit ecb5bb4ed8
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.config/CredScanSuppressions.json
View File

@@ -16,6 +16,10 @@
{ {
"file": ".devcontainer\\devcontainer.json", "file": ".devcontainer\\devcontainer.json",
"_justification": "Local development environment - not used in production" "_justification": "Local development environment - not used in production"
},
{
"file": "extensions\\asde-deployment\\notebooks\\edge\\deploy-sql-edge-remote.ipynb",
"_justification": "Deployment Notebook - usernames/passwords are entered by user"
} }
] ]
} }

1
extensions/cms/src/cmsUtils.ts
View File

@@ -32,6 +32,7 @@ export class CmsUtils {
private _cmsService: mssql.ICmsService; private _cmsService: mssql.ICmsService;
private _registeredCmsServers: ICmsResourceNodeInfo[] = []; private _registeredCmsServers: ICmsResourceNodeInfo[] = [];
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Used for unit testing, not actual valid credential")]
public async savePassword(username: string, password: string): Promise<boolean> { public async savePassword(username: string, password: string): Promise<boolean> {
let provider = await this.credentialProvider(); let provider = await this.credentialProvider();
let result = await provider.saveCredential(username, password); let result = await provider.saveCredential(username, password);

2
src/sql/platform/connection/test/common/connectionStore.test.ts
View File

@@ -26,7 +26,7 @@ suite('ConnectionStore', () => {
serverName: 'namedServer', serverName: 'namedServer',
databaseName: 'bcd', databaseName: 'bcd',
authenticationType: 'SqlLogin', authenticationType: 'SqlLogin',
userName: 'cde', userName: 'cde', // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Mock value, never actually used to connect")]
password: generateUuid(), password: generateUuid(),
savePassword: true, savePassword: true,
groupId: '', groupId: '',