refactored collapsing widget, fixed refreshing a collapsed widget (#1107)

This commit is contained in:
Anthony Dresser
2018-04-11 14:39:23 -07:00
committed by GitHub
parent 087a6a0810
commit ed10f984b6
2 changed files with 14 additions and 12 deletions

View File

@@ -210,7 +210,6 @@ export class CollapseWidgetAction extends Action {
private _uri: string,
private _widgetUuid: string,
private collpasedState: boolean,
private collapsedStateChangedEvent: Event<boolean>,
@IAngularEventingService private _angularEventService: IAngularEventingService
) {
super(
@@ -218,7 +217,6 @@ export class CollapseWidgetAction extends Action {
collpasedState ? CollapseWidgetAction.EXPAND_LABEL : CollapseWidgetAction.COLLPASE_LABEL,
collpasedState ? CollapseWidgetAction.EXPAND_ICON : CollapseWidgetAction.COLLAPSE_ICON
);
this.collapsedStateChangedEvent(collapsed => this._updateState(collapsed));
}
run(): TPromise<boolean> {
@@ -232,8 +230,15 @@ export class CollapseWidgetAction extends Action {
}
private _updateState(collapsed: boolean): void {
if (collapsed === this.collpasedState) {
return;
}
this.collpasedState = collapsed;
this._setClass(this.collpasedState ? CollapseWidgetAction.EXPAND_ICON : CollapseWidgetAction.COLLAPSE_ICON);
this._setLabel(this.collpasedState ? CollapseWidgetAction.EXPAND_LABEL : CollapseWidgetAction.COLLPASE_LABEL);
}
public set state(collapsed: boolean) {
this._updateState(collapsed);
}
}