From eda25f72c167d21c59c490003e7ccf933d2b7b0e Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Tue, 12 May 2020 09:03:39 -0700 Subject: [PATCH] Improve logging for MSSQL errors to handle HTTP request errors (#10348) * Improve logging for MSSQL errors to handle HTTP request errors * stringify --- extensions/mssql/src/utils.ts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/extensions/mssql/src/utils.ts b/extensions/mssql/src/utils.ts index 95d206ae50..a99cf944de 100644 --- a/extensions/mssql/src/utils.ts +++ b/extensions/mssql/src/utils.ts @@ -187,7 +187,17 @@ export function verifyPlatform(): Thenable { } export function getErrorMessage(error: Error | any, removeHeader: boolean = false): string { - let errorMessage: string = (error instanceof Error) ? error.message : error.toString(); + let errorMessage: string; + if (error instanceof Error) { + errorMessage = error.message; + } else if (error.responseText) { + errorMessage = error.responseText; + if (error.status) { + errorMessage += ` (${error.status})`; + } + } else { + errorMessage = JSON.stringify(error.toString()); + } if (removeHeader) { errorMessage = removeErrorHeader(errorMessage); }