ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove container registry from arc control deploy (#12392)

Browse Source
This commit is contained in:
Charles Gagnon
2020-09-17 13:59:25 -07:00
committed by GitHub
parent a0886b9152
commit ee523fb512
3 changed files with 0 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/arc/notebooks/arcDeployment/deploy.arc.control.plane.ipynb
View File

@@ -129,8 +129,6 @@
{
"cell_type": "code",
"source": [
"if \"AZDATA_NB_VAR_ARC_DOCKER_PASSWORD\" in os.environ:\n",
" arc_docker_password = os.environ[\"AZDATA_NB_VAR_ARC_DOCKER_PASSWORD\"]\n",
"if \"AZDATA_NB_VAR_ARC_ADMIN_PASSWORD\" in os.environ:\n",
" arc_admin_password = os.environ[\"AZDATA_NB_VAR_ARC_ADMIN_PASSWORD\"]\n",
"else:\n",
@@ -188,8 +186,6 @@
"os.environ[\"ACCEPT_EULA\"] = 'yes'\n",
"os.environ[\"AZDATA_USERNAME\"] = arc_admin_username\n",
"os.environ[\"AZDATA_PASSWORD\"] = arc_admin_password\n",
"os.environ[\"DOCKER_USERNAME\"] = arc_docker_username\n",
"os.environ[\"DOCKER_PASSWORD\"] = arc_docker_password\n",
"if os.name == 'nt':\n",
" print(f'If you don\\'t see output produced by azdata, you can run the following command in a terminal window to check the deployment status:\\n\\t {os.environ[\"AZDATA_NB_VAR_KUBECTL\"]} get pods -n {arc_data_controller_namespace}')\n",
"run_command(f'azdata arc dc create --connectivity-mode {arc_data_controller_connectivity_mode} -n {arc_data_controller_name} -ns {arc_data_controller_namespace} -s {arc_subscription} -g {arc_resource_group} -l {arc_data_controller_location} -sc {arc_data_controller_storage_class} --profile-name {arc_profile}')\n",

22
extensions/arc/package.json
View File

@@ -165,28 +165,6 @@
"configFileVariableName": "AZDATA_NB_VAR_ARC_CONFIG_FILE"
}
]
},
{
"title": "%arc.control.plane.container.registry.title%",
"fields": [
{
"label": "%arc.control.plane.container.registry.name%",
"variableName": "AZDATA_NB_VAR_ARC_DOCKER_USERNAME",
"type": "text",
"required": true,
"defaultValue": "22cda7bb-2eb1-419e-a742-8710c313fe79",
"enabled": true
},
{
"label": "%arc.control.plane.container.registry.password%",
"variableName": "AZDATA_NB_VAR_ARC_DOCKER_PASSWORD",
"type": "password",
"userName": "docker",
"confirmationRequired": false,
"defaultValue": "",
"required": true
}
]
}
]
},

3
extensions/arc/package.nls.json
View File

@@ -19,9 +19,6 @@
"arc.control.plane.cluster.environment.title": "What is your target existing Kubernetes cluster environment?",
"arc.control.plane.select.cluster.title": "Select from existing Kubernetes clusters",
"arc.control.plane.kube.cluster.context": "Cluster context",
"arc.control.plane.container.registry.title": "Container registry details",
"arc.control.plane.container.registry.name": "Container registry login",
"arc.control.plane.container.registry.password": "Container registry password",
"arc.control.plane.cluster.config.profile.title": "Choose the config profile",
"arc.control.plane.cluster.config.profile": "Config profile",
"arc.control.plane.data.controller.create.title": "Provide details to create Azure Arc data controller",