Add compile options to a few extensions (#8252)

* add compile options to a few extensions

* move dep to dev dep

* fix return types
This commit is contained in:
Anthony Dresser
2019-11-07 11:41:31 -08:00
committed by GitHub
parent b364e32beb
commit ef0a92d83f
68 changed files with 121 additions and 211 deletions

View File

@@ -43,9 +43,9 @@ export abstract class BasePage {
* Sets up a navigation validator.
* This will be called right before onPageEnter().
*/
public abstract setupNavigationValidator();
public abstract setupNavigationValidator(): void;
protected async getServerValues(): Promise<{ connection, displayName, name }[]> {
protected async getServerValues(): Promise<{ connection: azdata.connection.ConnectionProfile, displayName: string, name: string }[]> {
let cons = await azdata.connection.getConnections(/* activeConnectionsOnly */ true);
// This user has no active connections ABORT MISSION
if (!cons || cons.length === 0) {
@@ -105,7 +105,7 @@ export abstract class BasePage {
return values;
}
protected async getDatabaseValues(): Promise<{ displayName, name }[]> {
protected async getDatabaseValues(): Promise<{ displayName: string, name: string }[]> {
let idx = -1;
let count = -1;
let values = (await azdata.connection.listDatabases(this.model.server.connectionId)).map(db => {

View File

@@ -2,7 +2,6 @@
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
'use strict';
import * as azdata from 'azdata';
import * as nls from 'vscode-nls';
@@ -38,7 +37,7 @@ export abstract class DacFxConfigPage extends BasePage {
this.view = view;
}
public setupNavigationValidator() {
public setupNavigationValidator(): void {
this.instance.registerNavigationValidator(() => {
return true;
});
@@ -198,4 +197,3 @@ export abstract class DacFxConfigPage extends BasePage {
interface ConnectionDropdownValue extends azdata.CategoryValue {
connection: azdata.connection.ConnectionProfile;
}