ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-09 09:42:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add aria labels to buttons and spin inputs on Arc dashboards (#15798)

Browse Source
This commit is contained in:
Charles Gagnon
2021-06-17 19:38:27 -07:00
committed by GitHub
parent df296939a8
commit efd752aafe
4 changed files with 45 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
extensions/arc/src/ui/components/keyValueContainer.ts
View File

@@ -113,7 +113,8 @@ export abstract class BaseInputKeyValue extends KeyValue {
const copy = modelBuilder.button().withProperties<azdata.ButtonProperties>({
iconPath: IconPathHelper.copy,
width: '17px',
height: '17px'
height: '17px',
ariaLabel: loc.copyConnectionStringToClipboard(key)
}).component();
this.disposables.push(copy.onDidClick(async () => {

14
extensions/arc/src/ui/dashboards/miaa/miaaComputeAndStoragePage.ts
View File

@@ -183,7 +183,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coresLimit
}).component();
this.disposables.push(
@@ -200,7 +201,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coresRequest
}).component();
this.disposables.push(
@@ -217,7 +219,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 2,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.memoryLimit
}).component();
this.disposables.push(
@@ -234,7 +237,8 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 2,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.memoryRequest
}).component();
this.disposables.push(
@@ -274,7 +278,7 @@ export class MiaaComputeAndStoragePage extends DashboardPage {
}).component();
const keyComponent = this.modelView.modelBuilder.text().withProperties<azdata.TextComponentProperties>({
value: key,
value: `${key} :`,
CSSStyles: { ...cssStyles.text, 'margin-block-start': '0px', 'margin-block-end': '0px' }
}).component();

29
extensions/arc/src/ui/dashboards/postgres/postgresComputeAndStoragePage.ts
View File

@@ -247,7 +247,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
min: 0,
inputType: 'number',
placeHolder: loc.loading,
required: true
required: true,
ariaLabel: loc.workerNodeCount
}).component();
this.disposables.push(
@@ -265,7 +266,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.workerCoresRequest
}).component();
this.disposables.push(
@@ -285,7 +287,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.workerCoresLimit
}).component();
this.disposables.push(
@@ -305,7 +308,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 0.25,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.workerMemoryRequest
}).component();
this.disposables.push(
@@ -325,7 +329,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 0.25,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.workerMemoryLimit
}).component();
this.disposables.push(
@@ -345,7 +350,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coordinatorCoresRequest
}).component();
this.disposables.push(
@@ -365,7 +371,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 1,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coordinatorCoresLimit
}).component();
this.disposables.push(
@@ -385,7 +392,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 0.25,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coordinatorMemoryRequest
}).component();
this.disposables.push(
@@ -405,7 +413,8 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
readOnly: false,
min: 0.25,
inputType: 'number',
placeHolder: loc.loading
placeHolder: loc.loading,
ariaLabel: loc.coordinatorMemoryLimit
}).component();
this.disposables.push(
@@ -499,7 +508,7 @@ export class PostgresComputeAndStoragePage extends DashboardPage {
}).component();
const keyComponent = this.modelView.modelBuilder.text().withProps({
value: key,
value: `${key} :`,
CSSStyles: { ...cssStyles.text, 'margin-block-start': '0px', 'margin-block-end': '0px' }
}).component();