From effdf4f538883590fbaea21aa538b65a023d27c4 Mon Sep 17 00:00:00 2001 From: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Date: Tue, 21 Feb 2023 13:47:40 -0800 Subject: [PATCH] Stops Azure connection with the "Do not save" server group option from being stored in the default server group list. (#21997) * Fix Azure connections do not save to server group error * Revert unnecessary change --- src/sql/workbench/api/browser/mainThreadConnectionManagement.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/sql/workbench/api/browser/mainThreadConnectionManagement.ts b/src/sql/workbench/api/browser/mainThreadConnectionManagement.ts index 7f4b8487fa..1cd51e708e 100644 --- a/src/sql/workbench/api/browser/mainThreadConnectionManagement.ts +++ b/src/sql/workbench/api/browser/mainThreadConnectionManagement.ts @@ -169,8 +169,6 @@ export class MainThreadConnectionManagement extends Disposable implements MainTh } : undefined; if (connectionCompletionOptions && connectionCompletionOptions.saveConnection) { - // Somehow, connectionProfile.saveProfile is false even if initialConnectionProfile.saveProfile is true, reset the flag here. - connectionProfile.saveProfile = initialConnectionProfile.saveProfile; await this._connectionManagementService.connectAndSaveProfile(connectionProfile, undefined, { saveTheConnection: isUndefinedOrNull(connectionCompletionOptions.saveConnection) ? true : connectionCompletionOptions.saveConnection, showDashboard: isUndefinedOrNull(connectionCompletionOptions.showDashboard) ? false : connectionCompletionOptions.showDashboard,