fix edit data close (#8657)

This commit is contained in:
Anthony Dresser
2019-12-12 13:18:33 -08:00
committed by GitHub
parent 994a2382ad
commit f0dde491be
2 changed files with 4 additions and 13 deletions

View File

@@ -202,6 +202,10 @@ export class EditDataInput extends EditorInput implements IConnectableInput {
}
public dispose(): void {
// Dispose our edit session then disconnect our input
this._queryModelService.disposeEdit(this.uri).then(() => {
return this._connectionManagementService.disconnectEditor(this, true);
});
this._queryModelService.disposeQuery(this.uri);
this._sql.dispose();
this._results.dispose();
@@ -209,15 +213,6 @@ export class EditDataInput extends EditorInput implements IConnectableInput {
super.dispose();
}
public close(): void {
// Dispose our edit session then disconnect our input
this._queryModelService.disposeEdit(this.uri).then(() => {
return this._connectionManagementService.disconnectEditor(this, true);
}).then(() => {
this.dispose();
});
}
public get tabColor(): string {
return this._connectionManagementService.getTabColorForUri(this.uri);
}