ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

platformService tests and move tests from tdd to bdd (#13131)

Browse Source
This commit is contained in:
Arvind Ranasaria
2020-11-03 13:34:33 -08:00
committed by GitHub
parent 64510506e8
commit f10ac10f6d
12 changed files with 355 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
extensions/resource-deployment/src/test/ui/validation/validations.test.ts
View File

@@ -35,14 +35,14 @@ const testValidations = [
}
];
suite('Validation', () => {
suite('createValidation and validate input Box', () => {
setup(() => {
describe('Validation', () => {
describe('createValidation and validate input Box', () => {
beforeEach(() => {
sinon.restore(); //cleanup all previously defined sinon mocks
inputBoxStub = sinon.stub(inputBox, 'updateProperty').resolves();
});
testValidations.forEach(testObj => {
test(`validationType: ${testObj.type}`, async () => {
it(`validationType: ${testObj.type}`, async () => {
const validation = createValidation(testObj, async () => undefined, async (_varName: string) => undefined);
switch (testObj.type) {
case ValidationType.IsInteger: should(validation).be.instanceOf(IntegerValidation); break;
@@ -59,7 +59,7 @@ suite('Validation', () => {
});
});
suite('IntegerValidation', () => {
describe('IntegerValidation', () => {
// all the below test values are arbitrary representative values or sentinel values for integer validation
[
{ value: '342520596781', expected: true },
@@ -72,7 +72,7 @@ suite('Validation', () => {
{ value: NaN, expected: false },
].forEach((testObj) => {
const displayTestValue = getDisplayString(testObj.value);
test(`testValue:${displayTestValue}`, async () => {
it(`testValue:${displayTestValue}`, async () => {
const validationDescription = `value: ${displayTestValue} was not an integer`;
const validation = new IntegerValidation(
{ type: ValidationType.IsInteger, description: validationDescription },
@@ -83,7 +83,7 @@ suite('Validation', () => {
});
});
suite('RegexValidation', () => {
describe('RegexValidation', () => {
const testRegex = '^[0-9]+$';
// tests
[
@@ -97,7 +97,7 @@ suite('Validation', () => {
{ value: undefined, expected: false },
].forEach(testOb => {
const displayTestValue = getDisplayString(testOb.value);
test(`regex: /${testRegex}/, testValue:${displayTestValue}, expect result: ${testOb.expected}`, async () => {
it(`regex: /${testRegex}/, testValue:${displayTestValue}, expect result: ${testOb.expected}`, async () => {
const validationDescription = `value:${displayTestValue} did not match the regex:/${testRegex}/`;
const validation = new RegexValidation(
{ type: ValidationType.IsInteger, description: validationDescription, regex: testRegex },
@@ -108,7 +108,7 @@ suite('Validation', () => {
});
});
suite('LessThanOrEqualsValidation', () => {
describe('LessThanOrEqualsValidation', () => {
const targetVariableName = 'comparisonTarget';
// tests - when operands are mix of string and number then number comparison is performed
[
@@ -147,7 +147,7 @@ suite('Validation', () => {
].forEach(testObj => {
const displayTestValue = getDisplayString(testObj.value);
const displayTargetValue = getDisplayString(testObj.targetValue);
test(`testValue:${displayTestValue}, targetValue:${displayTargetValue}`, async () => {
it(`testValue:${displayTestValue}, targetValue:${displayTargetValue}`, async () => {
const validationDescription = `${displayTestValue} did not test as <= ${displayTargetValue}`;
const validation = new LessThanOrEqualsValidation(
{ type: ValidationType.IsInteger, description: validationDescription, target: targetVariableName },
@@ -159,7 +159,7 @@ suite('Validation', () => {
});
});
suite('GreaterThanOrEqualsValidation', () => {
describe('GreaterThanOrEqualsValidation', () => {
const targetVariableName = 'comparisonTarget';
// tests - when operands are mix of string and number then number comparison is performed
[
@@ -190,7 +190,7 @@ suite('Validation', () => {
].forEach(testObj => {
const displayTestValue = getDisplayString(testObj.value);
const displayTargetValue = getDisplayString(testObj.targetValue);
test(`testValue:${displayTestValue}, targetValue:${displayTargetValue}`, async () => {
it(`testValue:${displayTestValue}, targetValue:${displayTargetValue}`, async () => {
const validationDescription = `${displayTestValue} did not test as >= ${displayTargetValue}`;
const validation = new GreaterThanOrEqualsValidation(
{ type: ValidationType.IsInteger, description: validationDescription, target: targetVariableName },