ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing integration test due to notebook context menu (#5986)

Browse Source 
- Updated test baselines
- Removed duplicate 'Standard SQL DB context menu test'
 -  it's identical to Azure test
 - Standalone database context menu test covers non-Azure
This commit is contained in:
Kevin Cunnane
2019-06-11 16:09:12 -07:00
committed by GitHub
parent 33a9f2e3e4
commit f1e38b655e
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
extensions/integration-tests/src/objectExplorer.test.ts
View File

@@ -18,15 +18,12 @@ if (context.RunTest) {
test('BDC instance node label test', async function () { test('BDC instance node label test', async function () {
await (new ObjectExplorerTester()).bdcNodeLabelTest(); await (new ObjectExplorerTester()).bdcNodeLabelTest();
}); });
test('Standard alone instance node label test', async function () { test('Standalone instance node label test', async function () {
await (new ObjectExplorerTester()).standaloneNodeLabelTest(); await (new ObjectExplorerTester()).standaloneNodeLabelTest();
}); });
test('Azure SQL DB instance node label test', async function () { test('Azure SQL DB instance node label test', async function () {
await (new ObjectExplorerTester()).sqlDbNodeLabelTest(); await (new ObjectExplorerTester()).sqlDbNodeLabelTest();
}); });
test('Standard SQL DB context menu test', async function () {
await (new ObjectExplorerTester()).sqlDbContextMenuTest();
});
test('BDC instance context menu test', async function () { test('BDC instance context menu test', async function () {
await (new ObjectExplorerTester()).bdcContextMenuTest(); await (new ObjectExplorerTester()).bdcContextMenuTest();
}); });
@@ -67,14 +64,14 @@ class ObjectExplorerTester {
@stressify({ dop: ObjectExplorerTester.ParallelCount }) @stressify({ dop: ObjectExplorerTester.ParallelCount })
async sqlDbContextMenuTest(): Promise<void> { async sqlDbContextMenuTest(): Promise<void> {
let server = await getStandaloneServer(); let server = await getAzureServer();
let expectedActions: string[]; let expectedActions: string[];
// Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms // Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms
if (process.platform === 'win32') { if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler', 'Properties']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
} }
else { else {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler'];
} }
await this.verifyContextMenu(server, expectedActions); await this.verifyContextMenu(server, expectedActions);
} }
@@ -84,10 +81,10 @@ class ObjectExplorerTester {
let server = await getStandaloneServer(); let server = await getStandaloneServer();
let expectedActions: string[] = []; let expectedActions: string[] = [];
if (process.platform === 'win32') { if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard', 'Generate Scripts...', 'Properties']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard', 'Generate Scripts...', 'Properties'];
} }
else { else {
expectedActions = ['Manage', 'New Query', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Backup', 'Restore', 'Refresh', 'Data-tier Application wizard', 'Schema Compare', 'Import wizard'];
} }
await this.verifyDBContextMenu(server, 3000, expectedActions); await this.verifyDBContextMenu(server, 3000, expectedActions);
} }
@@ -98,10 +95,10 @@ class ObjectExplorerTester {
let expectedActions: string[]; let expectedActions: string[];
// Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms // Properties comes from the admin-tool-ext-win extension which is for Windows only, so the item won't show up on non-Win32 platforms
if (process.platform === 'win32') { if (process.platform === 'win32') {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler', 'Properties']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler', 'Properties'];
} }
else { else {
expectedActions = ['Manage', 'New Query', 'Disconnect', 'Delete Connection', 'Refresh', 'New Notebook', 'Data-tier Application wizard', 'Launch Profiler']; expectedActions = ['Manage', 'New Query', 'New Notebook', 'Disconnect', 'Delete Connection', 'Refresh', 'Data-tier Application wizard', 'Launch Profiler'];
} }
await this.verifyContextMenu(server, expectedActions); await this.verifyContextMenu(server, expectedActions);
} }