Add typing for TabbedPanelLayout and set defaults (#9955)

* Add typing for TabbedPanelLayout on withLayout and set appropriate defaults

* Move enum def
This commit is contained in:
Charles Gagnon
2020-04-15 16:42:42 -07:00
committed by GitHub
parent 3566da328a
commit f44e78aef4
4 changed files with 22 additions and 15 deletions

View File

@@ -13,6 +13,7 @@ import * as azdata from 'azdata';
import { SqlMainContext, ExtHostModelViewDialogShape, MainThreadModelViewDialogShape, ExtHostModelViewShape, ExtHostBackgroundTaskManagementShape } from 'sql/workbench/api/common/sqlExtHost.protocol';
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
import { TabOrientation } from 'sql/workbench/api/common/sqlExtHostTypes';
const DONE_LABEL = nls.localize('dialogDoneLabel', "Done");
const CANCEL_LABEL = nls.localize('dialogCancelLabel', "Cancel");
@@ -481,7 +482,7 @@ class ModelViewDashboardImpl implements azdata.window.ModelViewDashboard {
const dashboardTabs = await handler(view);
const tabs = this.createTabs(dashboardTabs, view);
this._tabbedPanel = view.modelBuilder.tabbedPanel().withTabs(tabs).withLayout({
orientation: 'vertical',
orientation: TabOrientation.Vertical,
showIcon: this._options?.showIcon ?? true,
alwaysShowTabs: this._options?.alwaysShowTabs ?? false
}).component();

View File

@@ -836,7 +836,6 @@ export enum TabOrientation {
Horizontal = 'horizontal'
}
export interface TabbedPanelLayout {
orientation: TabOrientation;
showIcon: boolean;