From f5b1e7feb89c7f7d76d12bc77cbb3569509a59a1 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Fri, 5 Nov 2021 11:08:43 -0700 Subject: [PATCH] a couple properties pane UI changes (#17601) --- src/sql/base/browser/ui/designer/designer.ts | 2 +- src/sql/base/browser/ui/designer/designerPropertiesPane.ts | 7 +++---- src/sql/base/browser/ui/designer/media/designer.css | 5 +++++ 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/sql/base/browser/ui/designer/designer.ts b/src/sql/base/browser/ui/designer/designer.ts index ace05e95dc..f6d0118baf 100644 --- a/src/sql/base/browser/ui/designer/designer.ts +++ b/src/sql/base/browser/ui/designer/designer.ts @@ -531,7 +531,7 @@ export class Designer extends Disposable implements IThemable { }); } else { groupNames.forEach(group => { - const groupHeader = container.appendChild(DOM.$('div.full-row')); + const groupHeader = container.appendChild(DOM.$('div.full-row.group-header')); groupHeaders.push(groupHeader); this.styleGroupHeader(groupHeader); groupHeader.innerText = group ?? localize('designer.generalGroupName', "General"); diff --git a/src/sql/base/browser/ui/designer/designerPropertiesPane.ts b/src/sql/base/browser/ui/designer/designerPropertiesPane.ts index e59ee36b7a..ea40800610 100644 --- a/src/sql/base/browser/ui/designer/designerPropertiesPane.ts +++ b/src/sql/base/browser/ui/designer/designerPropertiesPane.ts @@ -4,7 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import { CreateComponentsFunc, DesignerUIComponent, SetComponentValueFunc } from 'sql/base/browser/ui/designer/designer'; -import { DesignerViewModel, DesignerDataPropertyInfo, InputBoxProperties, NameProperty } from 'sql/base/browser/ui/designer/interfaces'; +import { DesignerViewModel, DesignerDataPropertyInfo } from 'sql/base/browser/ui/designer/interfaces'; import * as DOM from 'vs/base/browser/dom'; import { equals } from 'vs/base/common/objects'; import { localize } from 'vs/nls'; @@ -69,11 +69,10 @@ export class DesignerPropertiesPane { }; }); } - const name = (item.viewModel[NameProperty])?.value ?? ''; this._titleElement.innerText = localize({ key: 'tableDesigner.propertiesPaneTitleWithContext', - comment: ['{0} is the place holder for object type', '{1} is the place holder for object name'] - }, "Properties - {0} {1}", item.type, name); + comment: ['{0} is the place holder for object type'] + }, "{0} Properties", item.type); this._componentMap.forEach((value) => { this._setComponentValue(value.defintion, value.component, item.viewModel); }); diff --git a/src/sql/base/browser/ui/designer/media/designer.css b/src/sql/base/browser/ui/designer/media/designer.css index ee0195d849..2292beca9c 100644 --- a/src/sql/base/browser/ui/designer/media/designer.css +++ b/src/sql/base/browser/ui/designer/media/designer.css @@ -97,3 +97,8 @@ .designer-component .content-container .tabbedPanel { border-width: 0px; } + +.designer-component .components-grid .full-row.group-header { + font-weight: bold; + line-height: 25px; +}