Revert "Connection Store Refactor (#4632)" (#4671)

This reverts commit 756f77063a.
This commit is contained in:
Anthony Dresser
2019-03-22 11:30:20 -07:00
committed by GitHub
parent 8d5f676039
commit f5c9174c2f
19 changed files with 1008 additions and 897 deletions

View File

@@ -25,11 +25,11 @@ export const ICredentialsService = createDecorator<ICredentialsService>(SERVICE_
export interface ICredentialsService {
_serviceBrand: any;
saveCredential(credentialId: string, password: string): Promise<boolean>;
saveCredential(credentialId: string, password: string): Thenable<boolean>;
readCredential(credentialId: string): Promise<azdata.Credential>;
readCredential(credentialId: string): Thenable<azdata.Credential>;
deleteCredential(credentialId: string): Promise<boolean>;
deleteCredential(credentialId: string): Thenable<boolean>;
addEventListener(handle: number, events: CredentialManagementEvents): IDisposable;
}
@@ -62,15 +62,15 @@ export class CredentialsService implements ICredentialsService {
};
}
public saveCredential(credentialId: string, password: string): Promise<boolean> {
public saveCredential(credentialId: string, password: string): Thenable<boolean> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onSaveCredential(credentialId, password));
}
public readCredential(credentialId: string): Promise<azdata.Credential> {
public readCredential(credentialId: string): Thenable<azdata.Credential> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onReadCredential(credentialId));
}
public deleteCredential(credentialId: string): Promise<boolean> {
public deleteCredential(credentialId: string): Thenable<boolean> {
return this._onServerEventsReady.promise.then(() => this._serverEvents[this._lastHandle].onDeleteCredential(credentialId));
}

View File

@@ -1,44 +0,0 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
'use strict';
import { ICredentialsService, CredentialManagementEvents } from 'sql/platform/credentials/common/credentialsService';
import { Credential } from 'azdata';
import { IDisposable } from 'vs/base/common/lifecycle';
import { Emitter } from 'vs/base/common/event';
export class TestCredentialsService implements ICredentialsService {
_serviceBrand: any;
public credentials = new Map<string, Credential>();
private _onCredential = new Emitter<Credential>();
public readonly onCredential = this._onCredential.event;
saveCredential(credentialId: string, password: string): Promise<boolean> {
let credential = { credentialId, password };
this.credentials.set(credentialId, credential);
this._onCredential.fire(credential);
return Promise.resolve(true);
}
readCredential(credentialId: string): Promise<Credential> {
let cred = this.credentials.get(credentialId);
if (cred) {
return Promise.resolve<Credential>(cred);
} else {
return Promise.reject('');
}
}
deleteCredential(credentialId: string): Promise<boolean> {
return Promise.resolve(this.credentials.delete(credentialId));
}
addEventListener(handle: number, events: CredentialManagementEvents): IDisposable {
throw new Error('Method not implemented.');
}
}