From f6497a9ac43f0a0d575974b0f44b0a900ffb57f1 Mon Sep 17 00:00:00 2001 From: Aditya Bist Date: Mon, 18 Dec 2017 14:45:54 -0800 Subject: [PATCH] Context menu bug in macOS fixed (#350) * context menu now doesnt show in origin on mac * fixed context menu action being called twice in macOS --- .../connectionDialog/recentConnectionTreeController.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/sql/parts/connection/connectionDialog/recentConnectionTreeController.ts b/src/sql/parts/connection/connectionDialog/recentConnectionTreeController.ts index 008ac1d2bc..07b91384ea 100644 --- a/src/sql/parts/connection/connectionDialog/recentConnectionTreeController.ts +++ b/src/sql/parts/connection/connectionDialog/recentConnectionTreeController.ts @@ -89,7 +89,7 @@ export class RecentConnectionTreeController extends DefaultController { protected onRightClick(tree: ITree, element: any, eventish: ICancelableEvent, origin: string = 'mouse'): boolean { this.clickcb(element, eventish, origin); - this.onContextMenu(tree, element, event); + this.showContextMenu(tree, element, event); return true; } @@ -113,7 +113,7 @@ export class RecentConnectionTreeController extends DefaultController { return super.onKeyDown(tree, event); } - public onContextMenu(tree: ITree, element: any, event: any): boolean { + public showContextMenu(tree: ITree, element: any, event: any): boolean { var actionContext: any; if (element instanceof ConnectionProfile) { @@ -136,7 +136,6 @@ export class RecentConnectionTreeController extends DefaultController { }, getActionsContext: () => (actionContext) }); - return true; } } \ No newline at end of file