From f66d3349b912b156a3ab108406228d8a496a0d27 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Mon, 17 Apr 2023 08:19:59 -0700 Subject: [PATCH] add tooltip for dashboard learn more button (#22744) --- src/sql/workbench/contrib/dashboard/browser/core/actions.ts | 2 ++ .../contrib/dashboard/browser/core/dashboardPage.component.ts | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/sql/workbench/contrib/dashboard/browser/core/actions.ts b/src/sql/workbench/contrib/dashboard/browser/core/actions.ts index 7c6d4a1f28..5806a3c85b 100644 --- a/src/sql/workbench/contrib/dashboard/browser/core/actions.ts +++ b/src/sql/workbench/contrib/dashboard/browser/core/actions.ts @@ -68,12 +68,14 @@ export class ToolbarAction extends Action { constructor( id: string, label: string, + tooltip: string, cssClass: string, private runFn: (id: string) => void, private context: any, // this private logService: ILogService ) { super(id, label, cssClass); + this.tooltip = tooltip; } override async run(): Promise { diff --git a/src/sql/workbench/contrib/dashboard/browser/core/dashboardPage.component.ts b/src/sql/workbench/contrib/dashboard/browser/core/dashboardPage.component.ts index ba115323dc..94ce95d500 100644 --- a/src/sql/workbench/contrib/dashboard/browser/core/dashboardPage.component.ts +++ b/src/sql/workbench/contrib/dashboard/browser/core/dashboardPage.component.ts @@ -209,7 +209,7 @@ export abstract class DashboardPage extends AngularDisposable implements IConfig content = this.getToolbarContent(tabId); if (tabId === this.homeTabId) { const configureDashboardCommand = MenuRegistry.getCommand('configureDashboard'); - const configureDashboardAction = new ToolbarAction(configureDashboardCommand.id, configureDashboardCommand.title.toString(), TaskRegistry.getOrCreateTaskIconClassName(configureDashboardCommand), this.runAction, this, this.logService); + const configureDashboardAction = new ToolbarAction(configureDashboardCommand.id, configureDashboardCommand.title.toString(), nls.localize('dashboard.configureDashboardTooltip', "Learn more about how to configure the dashboard"), TaskRegistry.getOrCreateTaskIconClassName(configureDashboardCommand), this.runAction, this, this.logService); content.push({ action: configureDashboardAction }); } this.toolbar.setContent(content); @@ -272,7 +272,7 @@ export abstract class DashboardPage extends AngularDisposable implements IConfig _tasks.forEach(a => { const iconClassName = TaskRegistry.getOrCreateTaskIconClassName(a); const title = typeof a.title === 'string' ? a.title : a.title.value; - toolbarActions.push(new ToolbarAction(a.id, title, iconClassName, this.runAction, this, this.logService)); + toolbarActions.push(new ToolbarAction(a.id, title, title, iconClassName, this.runAction, this, this.logService)); }); let content: ITaskbarContent[] = [];