ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix object explorer session fails (#5256)

Browse Source 
* only start session if response successful

* added return type

* fixed OE tests

* format doc
This commit is contained in:
Aditya Bist
2019-04-30 11:45:52 -07:00
committed by GitHub
parent f7fc94520a
commit f70369c2a6
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/workbench/services/objectExplorer/common/objectExplorerService.ts
View File

@@ -227,7 +227,13 @@ export class ObjectExplorerService implements IObjectExplorerService {
* Gets called when session is created
*/
public onSessionCreated(handle: number, session: azdata.ObjectExplorerSession): void {
this.handleSessionCreated(session);
if (session && session.success) {
this.handleSessionCreated(session);
} else {
let errorMessage = session && session.errorMessage ? session.errorMessage :
nls.localize('OeSessionFailedError', 'Failed to create Object Explorer session');
error(errorMessage);
}
}
private async handleSessionCreated(session: azdata.ObjectExplorerSession): Promise<void> {
@@ -237,7 +243,7 @@ export class ObjectExplorerService implements IObjectExplorerService {
if (this._sessions[session.sessionId]) {
connection = this._sessions[session.sessionId].connection;
if (session && session.success && session.rootNode) {
if (session.success && session.rootNode) {
let server = this.toTreeNode(session.rootNode, null);
server.connection = connection;
server.session = session;