no-op is the object is disposed (#20236)

This commit is contained in:
Alan Ren
2022-08-03 10:45:11 -07:00
committed by GitHub
parent 453f8e5525
commit f72dbccc52

View File

@@ -344,6 +344,7 @@ export abstract class GridTableBase<T> extends Disposable implements IView {
private currentHeight: number; private currentHeight: number;
private dataProvider: HybridDataProvider<T>; private dataProvider: HybridDataProvider<T>;
private filterPlugin: HeaderFilter<T>; private filterPlugin: HeaderFilter<T>;
private isDisposed: boolean = false;
private columns: Slick.Column<T>[]; private columns: Slick.Column<T>[];
@@ -420,6 +421,9 @@ export abstract class GridTableBase<T> extends Disposable implements IView {
} }
public async onDidInsert() { public async onDidInsert() {
if (this.isDisposed) {
return;
}
if (!this.table) { if (!this.table) {
this.build(); this.build();
} }
@@ -853,6 +857,7 @@ export abstract class GridTableBase<T> extends Disposable implements IView {
} }
public override dispose() { public override dispose() {
this.isDisposed = true;
this.container.remove(); this.container.remove();
if (this.table) { if (this.table) {
this.table.dispose(); this.table.dispose();