ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix for issue 3065 (#3067)

Browse Source 
* fix for 3065

* remove the parameter, no need to save connection
This commit is contained in:
Alan Ren
2018-10-31 16:13:09 -07:00
committed by GitHub
parent 8ce1013a26
commit f7dcaa38ff
2 changed files with 22 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sql/parts/commandLine/common/commandLineService.ts
View File

@@ -27,8 +27,7 @@ export class CommandLineService implements ICommandLineProcessing {
@IQueryEditorService private _queryEditorService: IQueryEditorService, @IQueryEditorService private _queryEditorService: IQueryEditorService,
@IObjectExplorerService private _objectExplorerService: IObjectExplorerService, @IObjectExplorerService private _objectExplorerService: IObjectExplorerService,
@IEditorService private _editorService: IEditorService, @IEditorService private _editorService: IEditorService,
) ) {
{
let profile = null; let profile = null;
if (this._environmentService && this._environmentService.args.server) { if (this._environmentService && this._environmentService.args.server) {
profile = new ConnectionProfile(_capabilitiesService, null); profile = new ConnectionProfile(_capabilitiesService, null);
@@ -52,8 +51,7 @@ export class CommandLineService implements ICommandLineProcessing {
this.processCommandLine(); this.processCommandLine();
} else { } else {
registry.onNewProvider(e => { registry.onNewProvider(e => {
if (e.id === Constants.mssqlProviderName) if (e.id === Constants.mssqlProviderName) {
{
this.processCommandLine(); this.processCommandLine();
} }
}); });

3
src/sql/parts/connection/common/connectionManagementService.ts
View File

@@ -381,8 +381,7 @@ export class ConnectionManagementService extends Disposable implements IConnecti
resolve(this._connectionStatusManager.getOriginalOwnerUri(ownerUri)); resolve(this._connectionStatusManager.getOriginalOwnerUri(ownerUri));
} else { } else {
const options: IConnectionCompletionOptions = { const options: IConnectionCompletionOptions = {
// Should saving the connection be a command line switch? saveTheConnection: false,
saveTheConnection : true,
showConnectionDialogOnError: true, showConnectionDialogOnError: true,
showDashboard: purpose === 'dashboard', showDashboard: purpose === 'dashboard',
params: undefined, params: undefined,