From fa150fbe6747f7dce5249c788c6d0bf4c4561305 Mon Sep 17 00:00:00 2001 From: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Date: Wed, 27 Jan 2021 15:17:32 -0800 Subject: [PATCH] Initialize releases when creating remoteBookController (#14064) * Check that releases if not undefined * Initialize model with empty releases --- extensions/notebook/src/book/remoteBookController.ts | 1 - extensions/notebook/src/dialog/remoteBookDialogModel.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/extensions/notebook/src/book/remoteBookController.ts b/extensions/notebook/src/book/remoteBookController.ts index d9ae3a798f..9076f4d41c 100644 --- a/extensions/notebook/src/book/remoteBookController.ts +++ b/extensions/notebook/src/book/remoteBookController.ts @@ -25,7 +25,6 @@ export class RemoteBookController { public async getReleases(url?: vscode.Uri): Promise { if (url) { - this.model.releases = []; let options = { headers: { 'User-Agent': 'request' diff --git a/extensions/notebook/src/dialog/remoteBookDialogModel.ts b/extensions/notebook/src/dialog/remoteBookDialogModel.ts index f56eaef324..83a4d257ff 100644 --- a/extensions/notebook/src/dialog/remoteBookDialogModel.ts +++ b/extensions/notebook/src/dialog/remoteBookDialogModel.ts @@ -8,7 +8,7 @@ import { IRelease, IAsset } from '../book/remoteBookController'; export class RemoteBookDialogModel { private _remoteLocation: string; - private _releases: IRelease[]; + private _releases: IRelease[] = []; private _assets: IAsset[]; private _book: RemoteBook;