ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Windows extension fixes/improvements (#4740)

Browse Source 
* Windows extension fixes/improvements

Remove error message when activating extension on non-win platforms (instead just don't do anything). Add hooks to kill child processes on exit if they haven't ended already. Formatting fixes.

* Remove shelljs

* Remove error messages from telemetry until I can follow up on whether we're allowed to send these up. Fix some issues with the exec callback - the child_process exec function returns an ExecException object instead of the code directly like the shelljs did so check for that correctly.
This commit is contained in:
Charles Gagnon
2019-03-28 14:58:18 -07:00
committed by GitHub
parent e6785ffe95
commit fdb471d506
3 changed files with 97 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/admin-tool-ext-win/package.json
View File

@@ -52,7 +52,6 @@
},
"dependencies": {
"service-downloader": "github:anthonydresser/service-downloader#0.1.5",
"shelljs": "^0.7.5",
"vscode-extension-telemetry": "^0.0.15",
"vscode-nls": "^3.2.1"
},