ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix table designer issues (#18988)

Browse Source 
* fix table designer issues

* commit change on blur

* new sts
This commit is contained in:
Alan Ren
2022-04-10 12:09:33 -07:00
committed by GitHub
parent 9fcfe5b23c
commit fe1aefdd5f
5 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/mssql/config.json
View File

@@ -1,6 +1,6 @@
{ {
"downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/v{#version#}/microsoft.sqltools.servicelayer-{#fileName#}", "downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/v{#version#}/microsoft.sqltools.servicelayer-{#fileName#}",
"version": "3.0.0-release.227", "version": "3.0.0-release.229",
"downloadFileNames": { "downloadFileNames": {
"Windows_86": "win-x86-net6.0.zip", "Windows_86": "win-x86-net6.0.zip",
"Windows_64": "win-x64-net6.0.zip", "Windows_64": "win-x64-net6.0.zip",

3
src/sql/base/browser/ui/editableDropdown/browser/dropdown.ts
View File

@@ -101,9 +101,11 @@ export class Dropdown extends Disposable implements IListVirtualDelegate<string>
this._el = DOM.append(container, DOM.$('.monaco-dropdown')); this._el = DOM.append(container, DOM.$('.monaco-dropdown'));
this._el.style.width = '100%'; this._el.style.width = '100%';
this._el.style.height = '100%';
this._inputContainer = DOM.append(this._el, DOM.$('.dropdown-input.select-container')); this._inputContainer = DOM.append(this._el, DOM.$('.dropdown-input.select-container'));
this._inputContainer.style.width = '100%'; this._inputContainer.style.width = '100%';
this._inputContainer.style.height = '100%';
this._selectListContainer = DOM.$('div'); this._selectListContainer = DOM.$('div');
this._input = new InputBox(this._inputContainer, contextViewService, { this._input = new InputBox(this._inputContainer, contextViewService, {
@@ -166,7 +168,6 @@ export class Dropdown extends Disposable implements IListVirtualDelegate<string>
this._input.validate(); this._input.validate();
this._onBlur.fire(); this._onBlur.fire();
this._hideList(); this._hideList();
e.stopPropagation();
break; break;
case KeyCode.DownArrow: case KeyCode.DownArrow:
if (!this._isDropDownVisible) { if (!this._isDropDownVisible) {

5
src/sql/base/browser/ui/editableDropdown/browser/media/dropdownList.css
View File

@@ -17,3 +17,8 @@
width: 100%; width: 100%;
overflow: hidden; overflow: hidden;
} }
.monaco-dropdown .monaco-inputbox {
width: 100%;
height: 100%;
}

3
src/sql/base/browser/ui/table/tableCellEditorFactory.ts
View File

@@ -152,6 +152,9 @@ export class TableCellEditorFactory {
this._component.onValueChange(async () => { this._component.onValueChange(async () => {
await this.commitEdit(); await this.commitEdit();
}); });
this._component.onBlur(async () => {
await this.commitEdit();
});
} else { } else {
this._component = new SelectBox([], undefined, self._contextViewProvider); this._component = new SelectBox([], undefined, self._contextViewProvider);
this._component.render(container); this._component.render(container);

5
src/sql/workbench/services/tableDesigner/browser/tableDesignerMetadata.ts
View File

@@ -20,8 +20,8 @@ export class TableDesignerMetadata {
* @returns filtered telemetry info with only allowed metadata points * @returns filtered telemetry info with only allowed metadata points
*/ */
public static getTelemetryInfo(providerId: string, metadata: { [key: string]: string }): { [key: string]: string } { public static getTelemetryInfo(providerId: string, metadata: { [key: string]: string }): { [key: string]: string } {
if (!TableDesignerMetadata.providerMetadataMap.has(providerId)) { if (!TableDesignerMetadata.providerMetadataMap.has(providerId) || !metadata) {
return undefined; return {};
} }
const allowedSet = TableDesignerMetadata.providerMetadataMap.get(providerId); const allowedSet = TableDesignerMetadata.providerMetadataMap.get(providerId);
for (const key of Object.keys(metadata)) { for (const key of Object.keys(metadata)) {
@@ -31,5 +31,4 @@ export class TableDesignerMetadata {
} }
return metadata; return metadata;
} }
} }